Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PUZSOC-6049] Remove PRIME keys from environmentVariables output #92

Merged
merged 9 commits into from
Dec 1, 2023

Conversation

ebronson68
Copy link
Contributor

@ebronson68 ebronson68 commented Nov 20, 2023

PUZSOC-6049
Summary DevOps: Update key vault scripts to account for new Amazon Prime keys in TPS UI
Type Bug Bug
Status Peer Review
Points N/A
Labels ServiceDesk
---

Description

  • Remove PRIME_PUBLIC_KEY and PRIME_PRIVATE_KEY secrets from environmentVariables to fix ephemeral deployment workflow issues
  • Use build arguments in next-vars step instead of assuming all variables from the .env file would be build arguments.
  • Use NEXT_PUBLIC_B2C_TENANT_NAME environment variable if B2C_TENANT_NAME is missing when updating the B2C redirect URIs
  • Updated the comment search string in the step that posts a comment to the Jira ticket with the ephemeral deployment.

Related Links

@github-actions github-actions bot added bug Something isn't working Puzzle Society 2.0 labels Nov 20, 2023
@ebronson68 ebronson68 marked this pull request as ready for review November 22, 2023 15:26
@ebronson68 ebronson68 requested a review from a team as a code owner November 22, 2023 15:26
@ebronson68 ebronson68 merged commit 118aaff into main Dec 1, 2023
5 checks passed
@ebronson68 ebronson68 deleted the bug/PUZSOC-6049/fix-prime-keys branch December 1, 2023 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Puzzle Society 2.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants