Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DEVOPS-324] Use repository config files when running prettier #93

Merged
merged 2 commits into from
Dec 4, 2023

Conversation

ebronson68
Copy link
Contributor

@ebronson68 ebronson68 commented Dec 4, 2023

DEVOPS-324
Summary Prettier in simple lint workflow not respecting prettier config files
Type Story Story
Status In Progress
Points N/A
Labels -
---

Description

  • Use repository config files when running prettier

Related Links

@ebronson68 ebronson68 requested a review from a team as a code owner December 4, 2023 16:30
@github-actions github-actions bot added devops DevOps Team story New feature or request labels Dec 4, 2023
Copy link
Collaborator

@ctrble ctrble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just as an FYI, Prettier accepts a bunch of different config file types, https://prettier.io/docs/en/configuration.html. We probably have a few different ones in use, and I'm trying to migrate all configs over to .js instead of .json when I have time and they play nicely (not all do).

@amutechtest amutechtest removed the devops DevOps Team label Dec 4, 2023
@github-actions github-actions bot added the devops DevOps Team label Dec 4, 2023
@ebronson68 ebronson68 merged commit 8882c74 into main Dec 4, 2023
5 checks passed
@ebronson68 ebronson68 deleted the story/DEVOPS-324/fix-prettier-config-issues branch December 4, 2023 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
devops DevOps Team story New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants