Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closes BG-1041: A user should not be able to continue someone else's … #2637

Merged
merged 1 commit into from
Jan 9, 2024
Merged

Closes BG-1041: A user should not be able to continue someone else's … #2637

merged 1 commit into from
Jan 9, 2024

Conversation

ap-justin
Copy link
Collaborator

…registration (#2632)

  • Add email as part of checking for reg. reference

  • Revert "Add email as part of checking for reg. reference"

This reverts commit 7c5991d.

  • Add authorization header when getting reg. by reference

Explanation of the solution

Instructions on making this work

  • run yarn or yarn install to install npm dependencies
  • run yarn run test --watchAll to verify all tests still pass
  • (optional) run yarn run build to verify the build passes
  • run yarn start to start the webapp

UI changes for review

When major UI changes are introduced with a PR, please include links to URLS to compare or screenshots demonstrating the difference and notify on design changes

@ap-justin
Closes BG-1041: A user should not be able to continue someone else's …
b1cac06 
…registration (#2632)

* Add email as part of checking for reg. reference

* Revert "Add email as part of checking for reg. reference"

This reverts commit 7c5991d.

* Add authorization header when getting reg. by reference
@linear Linear
Copy link

linear bot commented Jan 9, 2024

BG-1041 A user should not be able to continue someone else's registration

@ap-justin ap-justin added bug Something isn't working duplicate This issue or pull request already exists labels Jan 9, 2024
@SovereignAndrey SovereignAndrey merged commit 83e336c into master Jan 9, 2024
1 check passed
@SovereignAndrey SovereignAndrey deleted the bg-1041 branch January 9, 2024 03:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SovereignAndrey SovereignAndrey SovereignAndrey approved these changes

@0xNeshi 0xNeshi Awaiting requested review from 0xNeshi

Assignees
No one assigned
Labels
bug Something isn't working duplicate This issue or pull request already exists
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ap-justin @SovereignAndrey