Add proper Nostr Zap Support #11
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AngusP
force-pushed
the
nostr-zap-support
branch
2 times, most recently
from
8e39080
to
d7df071
Compare
--- - Adds Phoenixd webhook endpoint `/phoenixd-webhook` (needs phoenixd config `webhook=http://localhost:8000/phoenixd-webhook`) - Create Nostr Zap Receipt events (requires new config `USER_NOSTR_PRIVATE_KEY=nsec1...`) - Publish Zap Receipt events to relays specified in the Zap Request event in a background task - Add tests for new Nostr behaviour
This was referenced Jun 14, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds Phoenixd webhook endpoint
/phoenixd-webhook(needs phoenixd configwebhook=http://localhost:8000/phoenixd-webhook)Create Nostr Zap Receipt events (requires new config
USER_NOSTR_PRIVATE_KEY=nsec1...)Publish Zap Receipt events to relays specified in the Zap Request event in a background task
Add tests for new Nostr behaviour
Nostr support for Docker, docker-compose. README update for new config and details.
Don't smuggle Nostr Zap request event in the invoice description as they are often longer than the BOLT-11 maximum allowable size of 639 bytes.
descriptionHashparameter tocreateinvoiceACINQ/phoenixd#50 andphoenixd 0.1.5releaseBut now that means we have to persist the zaps ourselves rather than lazily rely on phoenixd to remember them for us in invoice descriptions