Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Animated emoji Addition #1032

Merged
merged 3 commits into from
Aug 4, 2024
Merged

Conversation

Damini2004
Copy link
Contributor

Description

Animated emoji Addition

Related Issues

[Cite any related issue(s) this pull request addresses. If none, simply state “None”]

Type of PR

  • Bug fix
  • Feature enhancement
  • Documentation update
  • Other (specify): _______________

Screenshots / videos (if applicable)

[Attach any relevant screenshots or videos demonstrating the changes]

Checklist

  • I have gone through the contributing guide
  • I have updated my branch and synced it with project main branch before making this PR
  • I have performed a self-review of my code
  • I have tested the changes thoroughly before submitting this pull request.
  • I have provided relevant issue numbers, screenshots, and videos after making the changes.
  • I have commented my code, particularly in hard-to-understand areas.

Additional context:

[Include any additional information or context that might be helpful for reviewers.]

Copy link

vercel bot commented Jul 26, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
rapidoc ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 1, 2024 2:30pm

Copy link

netlify bot commented Jul 26, 2024

Deploy Preview for rapidoc ready!

Name Link
🔨 Latest commit 43ec511
🔍 Latest deploy log https://app.netlify.com/sites/rapidoc/deploys/66ab9bff01b50700077bf4fc
😎 Deploy Preview https://deploy-preview-1032--rapidoc.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, @Damini2004! 🎉 Thank you for submitting your pull request. Your contribution is valuable and we appreciate your efforts to improve our project.We will promptly review your changes and offer feedback. Keep up the excellent work! Kindly remember to check our contributing guidelines

const emoji = gif.getAttribute('data-emoji');
const gifSrc = gif.getAttribute('data-gif-src');
selectedEmojiElement.textContent = emoji;
selectedGifElement.src = gifSrc;

Check warning

Code scanning / CodeQL

DOM text reinterpreted as HTML Medium

DOM text
is reinterpreted as HTML without escaping meta-characters.
@Damini2004
Copy link
Contributor Author

@varshith257 review it.

@Damini2004
Copy link
Contributor Author

@varshith257 kinldy review and merge it.

@varshith257
Copy link
Collaborator

@Damini2004 Solve conflicts and tag me for quick review

@Damini2004
Copy link
Contributor Author

@varshith257 Does the conflicts get resolved ?

@Damini2004
Copy link
Contributor Author

@varshith257 review it.

@varshith257 varshith257 added gssoc level2 medium (enhancements) labels Aug 4, 2024
@varshith257 varshith257 merged commit 1a485b9 into Anishkagupta04:main Aug 4, 2024
8 checks passed
Copy link
Contributor

github-actions bot commented Aug 4, 2024

🎉 Your pull request has been successfully merged! 🎉 Thank you for your contribution to our project. Your efforts are greatly appreciated. Keep up the fantastic work! 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gssoc level2 medium (enhancements)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

✨[Feature Request]: Animated Emoji addition
2 participants