Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Google Authentication #1034

Merged
merged 4 commits into from
Jul 29, 2024
Merged

Conversation

Ojas-Arora
Copy link
Contributor

@Ojas-Arora Ojas-Arora commented Jul 26, 2024

Description

@varshith257 @Anishkagupta04 I have added Google Authentication, Password eye toggle, Javascript validations in Login/Signup form. Kindly make sure to add firebase file code from Firebase Console to add api keys of the Firebase for Authentication to work. Kindly review this.

Related Issues

[Cite any related issue(s) this pull request addresses. If none, simply state “None”]

Type of PR

  • Bug fix
  • Feature enhancement
  • Documentation update
  • Other (specify): _______________

Screenshots / videos (if applicable)

[Attach any relevant screenshots or videos demonstrating the changes]

Checklist

  • I have gone through the contributing guide
  • I have updated my branch and synced it with project main branch before making this PR
  • I have performed a self-review of my code
  • I have tested the changes thoroughly before submitting this pull request.
  • I have provided relevant issue numbers, screenshots, and videos after making the changes.
  • I have commented my code, particularly in hard-to-understand areas.

Additional context:

[Include any additional information or context that might be helpful for reviewers.]

Copy link

vercel bot commented Jul 26, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
rapidoc ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 28, 2024 8:18am

Copy link

netlify bot commented Jul 26, 2024

Deploy Preview for rapidoc ready!

Name Link
🔨 Latest commit a68cdef
🔍 Latest deploy log https://app.netlify.com/sites/rapidoc/deploys/66a5febebde4a50008bb0bc4
😎 Deploy Preview https://deploy-preview-1034--rapidoc.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, @Ojas-Arora! 🎉 Thank you for submitting your pull request. Your contribution is valuable and we appreciate your efforts to improve our project.We will promptly review your changes and offer feedback. Keep up the excellent work! Kindly remember to check our contributing guidelines

@Anjaliavv51
Copy link
Contributor

Anjaliavv51 commented Jul 27, 2024

@Ojas-Arora this branch is not updated , new branch contains forgetpass popup please rewrite the Google Authentication code in new branch , check in the below ss of ur deployment

image

Copy link
Contributor

@Anjaliavv51 Anjaliavv51 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Branch is not updated.

@Ojas-Arora
Copy link
Contributor Author

Ok I will update the Branch

@Ojas-Arora
Copy link
Contributor Author

Branch Updation Done

@Anjaliavv51
Copy link
Contributor

Branch Updation Done

image

@Ojas-Arora
Copy link
Contributor Author

Branch Updation Done

image

How can you see the deployment? It is not visible to me and you are able to see this..

@Anjaliavv51
Copy link
Contributor

@Ojas-Arora in below ss u can find the deploy preview in ur PR itself it can be accesed by anyone

image

@Ojas-Arora
Copy link
Contributor Author

@varshith257 @Anishkagupta04 Kindly review the PR as the Gssoc is about to end in some days.

@varshith257
Copy link
Collaborator

Can you fix conflicts and tag me?

@Ojas-Arora
Copy link
Contributor Author

Ok

@Ojas-Arora
Copy link
Contributor Author

@varshith257 Resolved the conflicts Kindly review now

@Ojas-Arora
Copy link
Contributor Author

@varshith257 @Anishkagupta04 Kindly review the PR as the Gssoc is about to end in 2 days.

@varshith257 varshith257 merged commit a68cdef into Anishkagupta04:main Jul 29, 2024
6 checks passed
Copy link
Contributor

🎉 Your pull request has been successfully merged! 🎉 Thank you for your contribution to our project. Your efforts are greatly appreciated. Keep up the fantastic work! 🚀

@Ojas-Arora
Copy link
Contributor Author

Ojas-Arora commented Jul 29, 2024

@varshith257 @Anjaliavv51 There is no level given for this . Kindly see this as early as possibel as Gssoc is going to end in 2 days.

@Ojas-Arora
Copy link
Contributor Author

@varshith257 @Anjaliavv51 Also There is no gssoc level . Without these There will be no gssoc points awarded to me.

@varshith257 varshith257 added gssoc level2 medium (enhancements) labels Jul 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gssoc level2 medium (enhancements)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

✨[Feature Request]: Adding Google Authentication
3 participants