-
Notifications
You must be signed in to change notification settings - Fork 256
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding Google Authentication #1034
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
✅ Deploy Preview for rapidoc ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job, @Ojas-Arora! 🎉 Thank you for submitting your pull request. Your contribution is valuable and we appreciate your efforts to improve our project.We will promptly review your changes and offer feedback. Keep up the excellent work! Kindly remember to check our contributing guidelines
@Ojas-Arora this branch is not updated , new branch contains forgetpass popup please rewrite the Google Authentication code in new branch , check in the below ss of ur deployment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Branch is not updated.
Ok I will update the Branch |
Branch Updation Done |
@Ojas-Arora in below ss u can find the deploy preview in ur PR itself it can be accesed by anyone |
@varshith257 @Anishkagupta04 Kindly review the PR as the Gssoc is about to end in some days. |
Can you fix conflicts and tag me? |
Ok |
@varshith257 Resolved the conflicts Kindly review now |
@varshith257 @Anishkagupta04 Kindly review the PR as the Gssoc is about to end in 2 days. |
🎉 Your pull request has been successfully merged! 🎉 Thank you for your contribution to our project. Your efforts are greatly appreciated. Keep up the fantastic work! 🚀 |
@varshith257 @Anjaliavv51 There is no level given for this . Kindly see this as early as possibel as Gssoc is going to end in 2 days. |
@varshith257 @Anjaliavv51 Also There is no gssoc level . Without these There will be no gssoc points awarded to me. |
Description
@varshith257 @Anishkagupta04 I have added Google Authentication, Password eye toggle, Javascript validations in Login/Signup form. Kindly make sure to add firebase file code from Firebase Console to add api keys of the Firebase for Authentication to work. Kindly review this.
Related Issues
[Cite any related issue(s) this pull request addresses. If none, simply state “None”]
Type of PR
Screenshots / videos (if applicable)
[Attach any relevant screenshots or videos demonstrating the changes]
Checklist
main
branch before making this PRAdditional context:
[Include any additional information or context that might be helpful for reviewers.]