Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

made the normaL check up page mobile responsive #1064

Closed
wants to merge 1 commit into from

Conversation

samarsajad
Copy link
Contributor

@samarsajad samarsajad commented Jul 29, 2024

Description

made the normaL CHECK UPS PAGE mobile RESPONSIVE

Related Issues

Type of PR

  • (Bug Fix)

Screenshots / videos (if applicable)

Checklist

  • I have gone through the contributing guide
  • I have updated my branch and synced it with project main branch before making this PR
  • I have performed a self-review of my code
  • I have tested the changes thoroughly before submitting this pull request.
  • I have provided relevant issue numbers, screenshots, and videos after making the changes.
  • [x
res.mp4

] I have commented my code, particularly in hard-to-understand areas.

Additional context:

Copy link

vercel bot commented Jul 29, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
rapidoc ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 29, 2024 9:13pm

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, @samarsajad! 🎉 Thank you for submitting your pull request. Your contribution is valuable and we appreciate your efforts to improve our project.We will promptly review your changes and offer feedback. Keep up the excellent work! Kindly remember to check our contributing guidelines

@samarsajad
Copy link
Contributor Author

Please review my pull request @varshith257

Copy link

netlify bot commented Jul 29, 2024

Deploy Preview for rapidoc ready!

Name Link
🔨 Latest commit 5f32dbb
🔍 Latest deploy log https://app.netlify.com/sites/rapidoc/deploys/66a80602008a770008fba2be
😎 Deploy Preview https://deploy-preview-1064--rapidoc.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@samarsajad samarsajad changed the title made the normaL CHECK UPS PAGE RESPONSIVE made the normaL check up page mobile responsive Jul 29, 2024
@media (max-width:768px) {
/* @media (max-width:768px) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why this commented?

@varshith257
Copy link
Collaborator

@Anjaliavv51 Take a look. I can see in deploy whole index.html is misaligned colliding items one upon one

@Anjaliavv51
Copy link
Contributor

@samarsajad please close this PR and also create a new branch , and do the changes

Screenshot_20240730_083750_Chrome

Screenshot_20240730_083745_Chrome

Screenshot_20240730_083736_Chrome

@Anjaliavv51
Copy link
Contributor

@samarsajad we can't let to effect the main repo due to these changes soo pls create new branch and also close this PR too.

@samarsajad
Copy link
Contributor Author

samarsajad commented Jul 30, 2024

please review my PR #1067 @Anjaliavv51 @varshith257
you asked me to create a new branch. in this PR you can clearly see that i have not changed any of the files that are linked with the main page. i just worked on the responsiveness of normal checkup page. so please review that page only while reviewing my pull request

@samarsajad samarsajad closed this Jul 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐞[Bug]: normal check up page is not mobile responsive
3 participants