Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The hamburger menu content is not visible in mobile screen view. #1142 #1153

Merged
merged 4 commits into from
Aug 9, 2024

Conversation

TaeMochi12
Copy link
Contributor

Description

The hamburger menu was not visible in the news section in mobile view, I've fixed it now.

Related Issues

None.

Type of PR

  • (Bug)

Screenshots / videos (if applicable)

Before:
Screenshot 2024-08-06 235657
After:
Screenshot 2024-08-06 235715

Checklist

  • I have gone through the contributing guide
  • I have updated my branch and synced it with project main branch before making this PR
  • I have performed a self-review of my code
  • I have tested the changes thoroughly before submitting this pull request.
  • I have provided relevant issue numbers, screenshots, and videos after making the changes.
  • I have commented my code, particularly in hard-to-understand areas.

Additional context:

Copy link

vercel bot commented Aug 6, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
rapidoc ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 9, 2024 0:15am

Copy link

netlify bot commented Aug 6, 2024

Deploy Preview for rapidoc ready!

Name Link
🔨 Latest commit fe9b9ee
🔍 Latest deploy log https://app.netlify.com/sites/rapidoc/deploys/66b60840c96cfd00080a3b1a
😎 Deploy Preview https://deploy-preview-1153--rapidoc.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, @TaeMochi12! 🎉 Thank you for submitting your pull request. Your contribution is valuable and we appreciate your efforts to improve our project.We will promptly review your changes and offer feedback. Keep up the excellent work! Kindly remember to check our contributing guidelines

@TaeMochi12
Copy link
Contributor Author

@varshith257 I've fixed the issue, kindly review the PR.

@varshith257
Copy link
Collaborator

@TaeMochi12 Can the navbar container align to left?

@TaeMochi12
Copy link
Contributor Author

@varshith257 Yes it can be done

@TaeMochi12
Copy link
Contributor Author

TaeMochi12 commented Aug 9, 2024

Screenshot 2024-08-09 173312
Screenshot 2024-08-09 174245

@varshith257 I've aligned the navbar container to the left both for home and news page in mobile view, please review once.

@varshith257 varshith257 added gssoc level2 medium (enhancements) labels Aug 9, 2024
@varshith257 varshith257 merged commit 99630b8 into Anishkagupta04:main Aug 9, 2024
7 checks passed
Copy link
Contributor

github-actions bot commented Aug 9, 2024

🎉 Your pull request has been successfully merged! 🎉 Thank you for your contribution to our project. Your efforts are greatly appreciated. Keep up the fantastic work! 🚀

@TaeMochi12
Copy link
Contributor Author

@varshith257 Thankyou so much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gssoc level2 medium (enhancements)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐞[Bug]: The hamburger menu content is not visible in mobile screen view.
2 participants