Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add files via upload #195

Closed

Conversation

KeshavPandia
Copy link

PR Description

Interactivity issues resolved.

Add your description

I have corrected the header and footer of the website. I have also created a favicon icon, which is the logo of the website near the title of the page. Also, i have corrected the positioning of the looping video in the right side which was interefering with the alignment of the navbar. Also i have added spaces between all the logos and the names of button in the navbar. And some other aligning here and there have also been rectified.

Issue

#17 Interactivity based on design

Checklist

  • [✔ ] I have gone through the [contributing guide](## PR Description

Add your description

Related Issues: Issue for which you are raising a PR for

  • Closes #

Issue

[Issue number or description]

Checklist

  • [✔ ] I have gone through the contributing guide
  • [ ✔] I have updated my branch and synced it with project main branch before making this PR
  • [ ✔] Is this a bug fix/enhancement/documentation changes

Undertaking

I declare that:

  1. The content I am submitting is original and has not been plagiarized.
  2. No portion of the work has been copied from any other source without proper attribution.
  3. The work has been checked for plagiarism, and I assure its authenticity.
  • [✔ ] I have updated my branch and synced it with project main branch before making this PR
  • [ ✔] Is this a bug fix/enhancement/documentation changes
  • [ ✔] Part of GSSOC
  • [ ✔] Tested for any breaking changes
  • [ ✔] Other relevant checks completed

I understand that any violation of this undertaking may have legal consequences that I will bear and could result in the withdrawal of any recognition associated with the work.

  • [✔ ] I Agree

I have corrected the header and footer of the website. I have also created a favicon icon, which is the logo of the website near the title of the page. Also, i have corrected the positioning of the looping video in the right side which was interefering with the alignment of the navbar. Also i have added spaces between all the logos and the names of button in the navbar. And some other aligning here and there have also been rectified.
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to Our repository.🎊 Thank you so much for taking the time to point this out.

@varshith257
Copy link
Collaborator

@KeshavPandia Why have this many lines of code changed? Looking like got the wrong merge. Closing, Please submit another PR

@KeshavPandia
Copy link
Author

@varshith257 Actually i have just changed 2-3 files but my code editor just formatted some other files as well basically their alignment but their content is still as it was there in original files you can check as well. So what should i do in this case?

@KeshavPandia
Copy link
Author

@varshith257 Kindy respond to my previous message. I am waiting for the next step :)

@varshith257
Copy link
Collaborator

Try the changes taking latest pull of upstream

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants