light/dark mode toggle button added #244
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
The sign is overlapping over Doctor section |
|
@aray1608 How without any code changes made a PR? |
varshith257
added
invalid
I had made changes in the index.html file |
|
Where are the changes? I can't see any file changes in the PR |
Sorry, just noticed that now. The pictures I have attached above reflect the changes I had made. I think I messed up while making the PR. In the meanwhile I am learning stuff and was planning to make some other changes too in the code, I'll fix that and make a new PR. Please give me some time. |
|
@aray1608 Raise the another PR when it's done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
I have added a light/dark mode toggle button. Although i had some issue with its placement, i hope it gets reviewed and any input is welcome.
Related Issues: Issue for which you are raising a PR for
The sight didnt have a light mode.
Issue
[Issue number or description]
Checklist
Add your description
Related Issues: Issue for which you are raising a PR for
Issue
[Issue number or description]
Checklist
mainbranch before making this PRUndertaking
I declare that:
mainbranch before making this PRI understand that any violation of this undertaking may have legal consequences that I will bear and could result in the withdrawal of any recognition associated with the work.