-
Notifications
You must be signed in to change notification settings - Fork 256
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added navbar and footer to news.html file #281
Conversation
@varshith257 ok |
Can send screenshot of changes? |
|
Is that current footer looks flaky |
@varshith257 Have to scroll a bit, the footer is the same as the home page |
@Anishkagupta04 PTAL and merge |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not looking nicee
@abhishekdumaniya Update based on suggestions |
@varshith257, @Anishkagupta004. Can you give me an idea of the UI |
@Anishkagupta04 PTAL |
Please send ss |
@Anishkagupta004 Can you provide me UI |
@Anishkagupta04 PTAl |
@varshith257 Can you merge my PR so that I can change some UI otherwise, a merge conflicts will occur |
Pull the latest changes and footer looks good now |
@varshith257 okay I saw it but why has the look of the navbar changed it doesn't look good please merge this PR of mine so that I can create a new PR and make other changes.............. Because I have worked hard on this PR so Please...... |
How's the navbar changes? Send ss |
@varshith257 The current home page which has a navbar looks like this, there is no news tag inside it But it looked like this |
Haven't noticed which PR made it. Will look at the culprit PR that merged for making these changes? I will revert that PR |
@varshith257 If you want, you can merge this PR of mine, and then I will solve the problem related to the navbar and small UI of the home page... |
Okay |
Is footer is fine of merged with new PR? Or it also got messed up |
@varshith257 The footer looks good but has a small spelling error I have a small request for you please check the PR and merge the UI of the whole website is not looking good |
It's hard for us to just see the code and except the changes of UI. After your PR got merged we will work on netifly deployment and will start PR reviews cc: @Anishkagupta04 Take a note of it. Don't merge any PRs more until we deploy netifly to our project |
🎉 Your pull request has been successfully merged! 🎉 Thank you for your contribution to our project. Your efforts are greatly appreciated. Keep up the fantastic work! 🚀 |
Create an issue and follow up on this bugs |
@varshith257 Thank you so much........... |
PR Description
added navbar and footer to the news.html file
Related Issues: Issue for which you are raising a PR for
Issue
[272]
Related Issues: Issue for which you are raising a PR for
Issue
[272]
Checklist
main
branch before making this PRUndertaking
I declare that:
main
branch before making this PRI understand that any violation of this undertaking may have legal consequences that I will bear and could result in the withdrawal of any recognition associated with the work.