Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added navbar and footer to news.html file #281

Merged
merged 5 commits into from
May 30, 2024

Conversation

abhishekdumaniya
Copy link
Contributor

PR Description

added navbar and footer to the news.html file

Related Issues: Issue for which you are raising a PR for

Issue

[272]

Related Issues: Issue for which you are raising a PR for

Issue

[272]

Checklist

  • I have gone through the contributing guide
  • I have updated my branch and synced it with project main branch before making this PR
  • Is this a bug fix/enhancement/documentation changes

Undertaking

I declare that:

  1. The content I am submitting is original and has not been plagiarized.
  2. No portion of the work has been copied from any other source without proper attribution.
  3. The work has been checked for plagiarism, and I assure its authenticity.
  • I have updated my branch and synced it with project main branch before making this PR
  • Is this a bug fix/enhancement/documentation changes
  • Part of GSSOC
  • Tested for any breaking changes
  • Other relevant checks completed

I understand that any violation of this undertaking may have legal consequences that I will bear and could result in the withdrawal of any recognition associated with the work.

  • I Agree

.vscode/settings.json Outdated Show resolved Hide resolved
@abhishekdumaniya
Copy link
Contributor Author

@varshith257 ok

@varshith257
Copy link
Collaborator

Can send screenshot of changes?

@abhishekdumaniya
Copy link
Contributor Author

Can send screenshot of changes?
@varshith257, I have uploaded the screen shot you can see
Screenshot 2024-05-23 174205

@varshith257
Copy link
Collaborator

Is that current footer looks flaky

@abhishekdumaniya
Copy link
Contributor Author

@varshith257 Have to scroll a bit, the footer is the same as the home page

Screenshot 2024-05-23 183238

@varshith257
Copy link
Collaborator

@Anishkagupta04 PTAL and merge

Copy link

@Anishkagupta004 Anishkagupta004 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not looking nicee

@varshith257
Copy link
Collaborator

@abhishekdumaniya Update based on suggestions

@abhishekdumaniya
Copy link
Contributor Author

@varshith257, @Anishkagupta004. Can you give me an idea of the UI

@varshith257
Copy link
Collaborator

varshith257 commented May 25, 2024

@Anishkagupta04 PTAL

@varshith257 varshith257 added enhancement New feature or request gssoc level2 medium (enhancements) labels May 25, 2024
@Anishkagupta04
Copy link
Owner

Please send ss

@abhishekdumaniya
Copy link
Contributor Author

abhishekdumaniya commented May 25, 2024

@Anishkagupta004 Can you provide me UI

@varshith257
Copy link
Collaborator

@Anishkagupta04 PTAl

@abhishekdumaniya
Copy link
Contributor Author

@varshith257 Can you merge my PR so that I can change some UI otherwise, a merge conflicts will occur

@varshith257
Copy link
Collaborator

Pull the latest changes and footer looks good now

@abhishekdumaniya
Copy link
Contributor Author

abhishekdumaniya commented May 30, 2024

@varshith257 okay I saw it but why has the look of the navbar changed it doesn't look good please merge this PR of mine so that I can create a new PR and make other changes.............. Because I have worked hard on this PR so Please......

@varshith257
Copy link
Collaborator

How's the navbar changes? Send ss

@abhishekdumaniya
Copy link
Contributor Author

@varshith257 The current home page which has a navbar looks like this, there is no news tag inside it
Screenshot 2024-05-30 225337

But it looked like this

Screenshot 2024-05-30 225712

@varshith257
Copy link
Collaborator

Haven't noticed which PR made it. Will look at the culprit PR that merged for making these changes? I will revert that PR

@abhishekdumaniya
Copy link
Contributor Author

@varshith257 If you want, you can merge this PR of mine, and then I will solve the problem related to the navbar and small UI of the home page...

@varshith257
Copy link
Collaborator

Okay

@varshith257
Copy link
Collaborator

Is footer is fine of merged with new PR? Or it also got messed up

@abhishekdumaniya
Copy link
Contributor Author

abhishekdumaniya commented May 30, 2024

@varshith257 The footer looks good but has a small spelling error
Contaact Us TYPO ---> Contact us

I have a small request for you please check the PR and merge the UI of the whole website is not looking good
Please merge this PR so that I can make future changes and create the best website UI
Thank You...............

@varshith257
Copy link
Collaborator

It's hard for us to just see the code and except the changes of UI. After your PR got merged we will work on netifly deployment and will start PR reviews

cc: @Anishkagupta04 Take a note of it. Don't merge any PRs more until we deploy netifly to our project

@varshith257 varshith257 added level3 hard (new feature) and removed level2 medium (enhancements) labels May 30, 2024
@varshith257 varshith257 merged commit 7e5fd0c into Anishkagupta04:main May 30, 2024
3 checks passed
Copy link
Contributor

🎉 Your pull request has been successfully merged! 🎉 Thank you for your contribution to our project. Your efforts are greatly appreciated. Keep up the fantastic work! 🚀

@varshith257
Copy link
Collaborator

Create an issue and follow up on this bugs

@abhishekdumaniya
Copy link
Contributor Author

@varshith257 Thank you so much...........

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request gssoc level3 hard (new feature)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

news.html does not have navbar and footer
4 participants