-
Notifications
You must be signed in to change notification settings - Fork 256
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed bugs under Doctors Section #337
Fixed bugs under Doctors Section #337
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome to Our repository.🎊 Thank you so much for taking the time to point this out.
@harshitagupta022 Can you link the issue you solving from this PR? If not, raise an issue and link it here. Thanks for contributing to our project |
This PR is in regard to issue #345. Sorry for the inconvenience. |
The screenshot is not visible to me. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.
@harshitagupta022 Take a look for changes and moving the logos to SVG is a good approach. So assigned as an enhancement of level2 |
I have tried to improve the cards under 'appoint a doctor' section and also fixed the bug due which swiper-slide navigation was not working. |
@Anishkagupta04 please review my code. |
Hey, please review my code. |
@harshitagupta022 I will review your PR. But what is the binary file you added DS_STORE? |
@varshith257 committed by mistake, removed it now. |
Can you post video of the changes or screenshots? |
Screen.Recording.2024-06-06.at.6.51.18.PM.mov |
@harshitagupta022 I think we also need calendar functionality there as @Anishkagupta04 suggested changed and also we can make it mobile responsive. Open an issue for them |
OK but since it has become a long PR can you please merge it and then I will open a new issue to raise a new PR. |
To get confirmation from you to open new issue , I had stopped it from merging |
🎉 Your pull request has been successfully merged! 🎉 Thank you for your contribution to our project. Your efforts are greatly appreciated. Keep up the fantastic work! 🚀 |
Description
Description under each section title was not visible because of black font color. Now it is visible. Resolved all the bugs under "appoint a doctor" of Doctors section.
Related Issues
[Cite any related issue(s) this pull request addresses. If none, simply state “None”]
Type of PR
Screenshots / videos (if applicable)
Before
After
Checklist
main
branch before making this PRAdditional context:
[Include any additional information or context that might be helpful for reviewers.]