Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed bugs under Doctors Section #337

Merged

Conversation

harshitagupta022
Copy link
Contributor

@harshitagupta022 harshitagupta022 commented May 27, 2024

Description

Description under each section title was not visible because of black font color. Now it is visible. Resolved all the bugs under "appoint a doctor" of Doctors section.

Related Issues

[Cite any related issue(s) this pull request addresses. If none, simply state “None”]

Type of PR

  • Bug fix
  • Feature enhancement
  • Documentation update
  • Other (specify): _______________

Screenshots / videos (if applicable)

Before
Screenshot 2024-05-25 at 5 39 41 PM
After
Screenshot 2024-05-27 at 4 55 05 PM

Checklist

  • I have gone through the contributing guide
  • I have updated my branch and synced it with project main branch before making this PR
  • I have performed a self-review of my code
  • I have tested the changes thoroughly before submitting this pull request.
  • I have provided relevant issue numbers, screenshots, and videos after making the changes.
  • I have commented my code, particularly in hard-to-understand areas.

Additional context:

[Include any additional information or context that might be helpful for reviewers.]

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to Our repository.🎊 Thank you so much for taking the time to point this out.

@varshith257
Copy link
Collaborator

@harshitagupta022 Can you link the issue you solving from this PR? If not, raise an issue and link it here. Thanks for contributing to our project

@harshitagupta022
Copy link
Contributor Author

This PR is in regard to issue #345. Sorry for the inconvenience.

@Anishkagupta04
Copy link
Owner

Uploading Screenshot_20240520_011121.jpg …
If possible could you please do like this

@harshitagupta022
Copy link
Contributor Author

The screenshot is not visible to me.

@Anishkagupta04
Copy link
Owner

Screenshot_20240520_011121.jpg

Copy link
Owner

@Anishkagupta04 Anishkagupta04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.

@varshith257 varshith257 added gssoc level1 easy (bug, documentaion) level2 medium (enhancements) and removed level1 easy (bug, documentaion) labels May 30, 2024
@varshith257
Copy link
Collaborator

@harshitagupta022 Take a look for changes and moving the logos to SVG is a good approach. So assigned as an enhancement of level2

@harshitagupta022
Copy link
Contributor Author

I have tried to improve the cards under 'appoint a doctor' section and also fixed the bug due which swiper-slide navigation was not working.

@harshitagupta022
Copy link
Contributor Author

@Anishkagupta04 please review my code.

@harshitagupta022
Copy link
Contributor Author

Hey, please review my code.

@varshith257
Copy link
Collaborator

@harshitagupta022 I will review your PR. But what is the binary file you added DS_STORE?

@harshitagupta022
Copy link
Contributor Author

@harshitagupta022 I will review your PR. But what is the binary file you added DS_STORE?

@varshith257 committed by mistake, removed it now.

@varshith257
Copy link
Collaborator

Can you post video of the changes or screenshots?

@harshitagupta022
Copy link
Contributor Author

Screen.Recording.2024-06-06.at.6.51.18.PM.mov

@varshith257 varshith257 added level3 hard (new feature) and removed level2 medium (enhancements) labels Jun 6, 2024
@varshith257
Copy link
Collaborator

@harshitagupta022 I think we also need calendar functionality there as @Anishkagupta04 suggested changed and also we can make it mobile responsive. Open an issue for them

@harshitagupta022
Copy link
Contributor Author

OK but since it has become a long PR can you please merge it and then I will open a new issue to raise a new PR.

@varshith257
Copy link
Collaborator

OK but since it has become a long PR can you please merge it and then I will open a new issue to raise a new PR.

To get confirmation from you to open new issue , I had stopped it from merging

@varshith257 varshith257 merged commit 3ebb235 into Anishkagupta04:main Jun 6, 2024
3 checks passed
Copy link
Contributor

github-actions bot commented Jun 6, 2024

🎉 Your pull request has been successfully merged! 🎉 Thank you for your contribution to our project. Your efforts are greatly appreciated. Keep up the fantastic work! 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gssoc level3 hard (new feature)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐞[Bug]: Text not visible and improper alignment of elements.
3 participants