Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐞[bug]:Signup with google isn't working #430

Merged
merged 25 commits into from
Jun 7, 2024
Merged

🐞[bug]:Signup with google isn't working #430

merged 25 commits into from
Jun 7, 2024

Conversation

Anjaliavv51
Copy link
Contributor

@Anjaliavv51 Anjaliavv51 commented Jun 4, 2024

Description

Fixes issue #427 signup with google button.

Related Issues

[Cite any related issue(s) this pull request addresses. If none, simply state “None”]

Type of PR

  • Bug fix
  • Feature enhancement
  • Documentation update
  • Other (specify): _______________

Screenshots / videos (if applicable)

20240604_142320.mp4

Signup in Login Form:

WhatsApp.Video.2024-06-04.at.14.41.13_79d8874c.mp4

Signup in Register Form:

WhatsApp.Video.2024-06-04.at.14.42.29_3c125a20.mp4

After Signup:

WhatsApp.Video.2024-06-04.at.14.44.11_39dc1ab8.mp4
WhatsApp.Video.2024-06-04.at.14.44.22_53884333.mp4

Checklist

  • I have gone through the contributing guide
  • I have updated my branch and synced it with project main branch before making this PR
  • I have performed a self-review of my code
  • I have tested the changes thoroughly before submitting this pull request.
  • I have provided relevant issue numbers, screenshots, and videos after making the changes.
  • I have commented my code, particularly in hard-to-understand areas.

Additional context:

Added a file one script file and html file.

Copy link

vercel bot commented Jun 4, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
rapidoc ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 7, 2024 3:24pm

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, @Anjaliavv51! 🎉 Thank you for submitting your pull request. Your contribution is valuable and we appreciate your efforts to improve our project.We will promptly review your changes and offer feedback. Keep up the excellent work! Kindly remember to check our contributing guidelines

@Anjaliavv51
Copy link
Contributor Author

@varshith257 @Anishkagupta04 please check i added Signup with google in two forms

@Anjaliavv51
Copy link
Contributor Author

@varshith257 @Anishkagupta04 please check i added Signup with google in two forms and also successfully completed signup page.

@varshith257
Copy link
Collaborator

@Anjaliavv51 Have you used firebase for it?

@Anjaliavv51
Copy link
Contributor Author

@varshith257 yes

@Anjaliavv51
Copy link
Contributor Author

@varshith257 is their any problem in using firebase?

@varshith257
Copy link
Collaborator

I will discuss it with Anishka. We are planning to add backend support so that it can be easy for this all

@Anjaliavv51
Copy link
Contributor Author

@varshith257 okay

@Anjaliavv51
Copy link
Contributor Author

@varshith257 any updates?

@varshith257 varshith257 added gssoc level3 hard (new feature) labels Jun 5, 2024
@Anjaliavv51
Copy link
Contributor Author

Anjaliavv51 commented Jun 5, 2024

@Anishkagupta04 please Review the CHanges

@Anishkagupta04
Copy link
Owner

Some error is there ig google page is not appearing

@Anjaliavv51
Copy link
Contributor Author

@Anishkagupta04 I will check it

@Anjaliavv51
Copy link
Contributor Author

@varshith257 please review the changes.

@Anjaliavv51
Copy link
Contributor Author

@Anishkagupta04 please review the changes.

@varshith257
Copy link
Collaborator

@Anishkagupta04 Preview it in vercel deployment

@Anjaliavv51
Copy link
Contributor Author

@Anishkagupta04 please review the changes

@Anjaliavv51
Copy link
Contributor Author

@varshith257 please check the PR

@varshith257 varshith257 merged commit 6bc7816 into Anishkagupta04:main Jun 7, 2024
3 checks passed
Copy link
Contributor

github-actions bot commented Jun 7, 2024

🎉 Your pull request has been successfully merged! 🎉 Thank you for your contribution to our project. Your efforts are greatly appreciated. Keep up the fantastic work! 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gssoc level3 hard (new feature)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants