Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

made counts and feature section on the landing page responsive #449

Merged
merged 7 commits into from
Jun 6, 2024

Conversation

Pruthaa17
Copy link
Contributor

@Pruthaa17 Pruthaa17 commented Jun 6, 2024

#364

made counts and feature section on the landing page responsive

Type of PR

  • Bug fix
  • Feature enhancement
  • Documentation update
  • Other (specify): _______________

Screenshots / videos (if applicable)

### EARLIER :

Screenshot (397)
Screenshot (398)
Screenshot (399)
Screenshot (400)
Screenshot (401)
Screenshot (402)

AFTER MAKING CHANGES

Screenshot (405)
Screenshot (406)
Screenshot (407)
Screenshot (408)

Checklist

  • I have gone through the contributing guide
  • I have updated my branch and synced it with project main branch before making this PR
  • I have performed a self-review of my code
  • I have tested the changes thoroughly before submitting this pull request.
  • I have provided relevant issue numbers, screenshots, and videos after making the changes.
  • I have commented my code, particularly in hard-to-understand areas.

Additional context:

[Include any additional information or context that might be helpful for reviewers.]

Copy link

vercel bot commented Jun 6, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
rapidoc ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 6, 2024 11:46am

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, @Pruthaa17! 🎉 Thank you for submitting your pull request. Your contribution is valuable and we appreciate your efforts to improve our project.We will promptly review your changes and offer feedback. Keep up the excellent work! Kindly remember to check our contributing guidelines

@varshith257
Copy link
Collaborator

varshith257 commented Jun 6, 2024

@Pruthaa17 Can you provide some more gap between elements here?

image

@varshith257
Copy link
Collaborator

And rest everything is fine

@Pruthaa17
Copy link
Contributor Author

@varshith257

Screenshot (409)

@Pruthaa17
Copy link
Contributor Author

Can you add label (level) to this pull request @varshith257

@varshith257
Copy link
Collaborator

@Pruthaa17 What is your expected level for it?

@Pruthaa17
Copy link
Contributor Author

@Pruthaa17 What is your expected level for it?

Perchance 3 ?? Because I worked on 2 sections simultaneously and also made them responsive !

@Pruthaa17
Copy link
Contributor Author

@varshith257 If I raised a issue for database connection for forms and various registrations which would you prefer ? MySQL or MongoDB

@varshith257
Copy link
Collaborator

varshith257 commented Jun 6, 2024

@varshith257 If I raised a issue for database connection for forms and various registrations which would you prefer ? MySQL or MongoDB

PostgreeSQL 😶‍🌫️

@varshith257
Copy link
Collaborator

@Pruthaa17 Ok! I will add level3 to this PR as your expected level. Here's a small task for you. You have correctly pointed to our current planning of backend support for this project

PostgreSQL is one I prefer as I worked with three of these dbs. But I can't say we use this only for our project as every usecase has other preferences over dbs in projects. Submit a report of your findings, why we prefer PostgreSQL for our project, and why not MongoDB and MySQL. Pros and cons of them and what you are suggesting to use finally based on your research?

I believe finally it could be worth it for both your curiosity about staying up to date with industry trends and project tech. If you have any queries or encounter any roadblocks in decision-making, ping me at discord/linkedin.

@varshith257 varshith257 added the level3 hard (new feature) label Jun 6, 2024
@varshith257
Copy link
Collaborator

@Anishkagupta04 FYI, I have added level3 for the my above comment

@varshith257 varshith257 merged commit 86b8ca0 into Anishkagupta04:main Jun 6, 2024
3 checks passed
Copy link
Contributor

github-actions bot commented Jun 6, 2024

🎉 Your pull request has been successfully merged! 🎉 Thank you for your contribution to our project. Your efforts are greatly appreciated. Keep up the fantastic work! 🚀

@Pruthaa17
Copy link
Contributor Author

Pruthaa17 commented Jun 6, 2024

@varshith257 Thanks , For putting up this discussion of preferences of Dbs. Previously I found most of the projects using MySQL and MongoDB so I didn't bothered about PostgreSQL but the fact the it is one of the mostly used DB for open source contribution !!

Thanks for the task it was indeed helpful !!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gssoc level3 hard (new feature)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

✨[Feature Request]: Counts Section is not a properly aligned
2 participants