Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨[feature request]:Wanted to replace a share button instead of Social icons #459

Closed
wants to merge 6 commits into from

Conversation

Anjaliavv51
Copy link
Contributor

@Anjaliavv51 Anjaliavv51 commented Jun 6, 2024

… icons

Resolves #428

Description

Replaced a share button to Social icons.

Type of PR

  • Bug fix
  • Feature enhancement
  • Documentation update
  • Other (specify): _______________

Screenshots / videos (if applicable)

image

Checklist

  • I have gone through the contributing guide
  • I have updated my branch and synced it with project main branch before making this PR
  • I have performed a self-review of my code
  • I have tested the changes thoroughly before submitting this pull request.
  • I have provided relevant issue numbers, screenshots, and videos after making the changes.
  • I have commented my code, particularly in hard-to-understand areas.

Copy link

vercel bot commented Jun 6, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
rapidoc ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 7, 2024 2:00pm

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, @Anjaliavv51! 🎉 Thank you for submitting your pull request. Your contribution is valuable and we appreciate your efforts to improve our project.We will promptly review your changes and offer feedback. Keep up the excellent work! Kindly remember to check our contributing guidelines

@Anjaliavv51
Copy link
Contributor Author

@varshith257 @Anishkagupta04 please review the changes , replacement of toggle share button instead of Social Icons.

@Anjaliavv51 Anjaliavv51 changed the title ✨[feature request]:Wanted to replace a share button instead of Social… ✨[feature request]:Wanted to replace a share button instead of Social icons Jun 6, 2024
@Anjaliavv51
Copy link
Contributor Author

Anjaliavv51 commented Jun 6, 2024

@varshith257 as u stated hover is also applied

image

Copy link
Contributor Author

@Anjaliavv51 Anjaliavv51 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review

@varshith257
Copy link
Collaborator

Better if we align as below reference by adding a Follow Us Section and keeping button in a way that splitting doesn't breaks by overlapping and also reduce some size of that button to align cleanly in footer

image

@varshith257
Copy link
Collaborator

@Anjaliavv51 I will review all of your issues and PRs by EOD

@Anjaliavv51
Copy link
Contributor Author

@varshith257 okay

@Anjaliavv51
Copy link
Contributor Author

@varshith257 please review my PR

@varshith257
Copy link
Collaborator

Any image or video of changes?

@Anjaliavv51
Copy link
Contributor Author

Any image or video of changes?

WhatsApp.Video.2024-06-07.at.19.46.44_333636a2.mp4

@Anjaliavv51
Copy link
Contributor Author

@varshith257 please check it

@varshith257
Copy link
Collaborator

Better if we add a Follow Us Section and align this button there as in attached image #459 (comment)

@Anjaliavv51
Copy link
Contributor Author

@varshith257 I will modify those changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

✨[feature request]: Redesigning of Footer for Better User Experience
2 participants