Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Div's in about us section were adjusted now in center with hover effect and appropriate color is given to icons and divs #527

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

SumithThota
Copy link

Description

Div's in about-us section is adjusted in center with hover effect and appropriate color is given to icons and divs

Type of PR

  • Bug fix
  • Feature enhancement
  • Documentation update
  • Other (specify): _______________

Screenshots / videos (if applicable)

Before

Screenshot 2024-06-11 185435

After

Screenshot 2024-06-11 174406
Screenshot 2024-06-11 174246

Rapidoc.1.1.mp4

Checklist

  • I have gone through the contributing guide
  • I have updated my branch and synced it with project main branch before making this PR
  • I have performed a self-review of my code
  • I have tested the changes thoroughly before submitting this pull request.
  • I have provided relevant issue numbers, screenshots, and videos after making the changes.
  • I have commented my code, particularly in hard-to-understand areas.

Copy link

vercel bot commented Jun 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
rapidoc ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 16, 2024 11:29am

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, @SumithThota! 🎉 Thank you for submitting your pull request. Your contribution is valuable and we appreciate your efforts to improve our project.We will promptly review your changes and offer feedback. Keep up the excellent work! Kindly remember to check our contributing guidelines

Copy link

netlify bot commented Jun 11, 2024

Deploy Preview for rapidoc ready!

Name Link
🔨 Latest commit a5eccbf
🔍 Latest deploy log https://app.netlify.com/sites/rapidoc/deploys/666ecca4b9aa9d0008cbb454
😎 Deploy Preview https://deploy-preview-527--rapidoc.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@SumithThota
Copy link
Author

Successfully completed the Assigned task :-)

@SumithThota SumithThota changed the title Div's adjusted in center with hover effect and appropriate color is given to icons and divs Div's in about us section were adjusted now in center with hover effect and appropriate color is given to icons and divs Jun 11, 2024
@Anishkagupta04
Copy link
Owner

i could not see any changes

@SumithThota
Copy link
Author

SumithThota commented Jun 11, 2024

  1. There was no hower affect(Animation) to the div's {Doctors available, beds available,Nearest Labs, User Reviews}
  2. The color of the icons in above Div's are able to change now, when you hover on it.
  3. When you Rapidoc in a large screen then all the Div are aligned to left but now it is fixed with center justification
  4. Bottom-width to the div's are added

@SumithThota
Copy link
Author

@Anishkagupta04, Please add level1 or level2 or level3 labels
(Note: There should not be any space in between level and number 1 or 2 or 3)

@varshith257
Copy link
Collaborator

@Anishkagupta04 Isn't this hover effect demoting our project color scheme?

@SumithThota
Copy link
Author

@Anishkagupta04 Isn't this hover effect demoting our project color scheme?

No, since I have checked your project color scheme and applied the same to those hover effect

@varshith257
Copy link
Collaborator

@Anishkagupta04 PTAL

@SumithThota
Copy link
Author

@Anishkagupta04 Check this PR and inform if any changes reqiured

@varshith257
Copy link
Collaborator

@SumithThota Can you fix conflicts?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants