Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed the navbar for responsive view. #644

Merged
merged 5 commits into from
Jun 21, 2024

Conversation

meetarora10
Copy link
Contributor

Description

I have made a completely responsive and properly aligned navbar for various devices.
I have added a hamburger icon which on click has a toggle effect on the navbar.

Related Issues

[Cite any related issue(s) this pull request addresses. If none, simply state “None”]

Type of PR

  • Bug fix
  • Feature enhancement
  • Documentation update
  • Other (specify): _______________

Screenshots / videos (if applicable)

[Attach any relevant screenshots or videos demonstrating the changes]
Screenshot (480)
Screenshot (481)

RapiDoc.-.Personal.-.Microsoft_.Edge.2024-06-19.10-01-09.mp4

Checklist

  • I have gone through the contributing guide
  • I have updated my branch and synced it with project main branch before making this PR
  • I have performed a self-review of my code
  • I have tested the changes thoroughly before submitting this pull request.
  • I have provided relevant issue numbers, screenshots, and videos after making the changes.
  • I have commented my code, particularly in hard-to-understand areas.

Additional context:

[Include any additional information or context that might be helpful for reviewers.]

Copy link

vercel bot commented Jun 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
rapidoc ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 20, 2024 6:00pm

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, @meetarora10! 🎉 Thank you for submitting your pull request. Your contribution is valuable and we appreciate your efforts to improve our project.We will promptly review your changes and offer feedback. Keep up the excellent work! Kindly remember to check our contributing guidelines

Copy link

netlify bot commented Jun 19, 2024

Deploy Preview for rapidoc ready!

Name Link
🔨 Latest commit d86d2e5
🔍 Latest deploy log https://app.netlify.com/sites/rapidoc/deploys/66746e3d4fdaf50008d686ee
😎 Deploy Preview https://deploy-preview-644--rapidoc.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@varshith257
Copy link
Collaborator

@meetarora10 Resolve conflicts

@meetarora10
Copy link
Contributor Author

@varshith257 resolved

@varshith257
Copy link
Collaborator

@meetarora10 Rather than in the center can you put the navbar items to the left and also give some consistent spacing among them

@meetarora10
Copy link
Contributor Author

@varshith257 I will do it.

@meetarora10
Copy link
Contributor Author

Screenshot (491)
Screenshot (490)
@varshith257 I have aligned navbar items in the left and also added some spacing as you said.

@meetarora10
Copy link
Contributor Author

@varshith257 please review this PR.

@varshith257 varshith257 added gssoc level2 medium (enhancements) labels Jun 20, 2024
@varshith257
Copy link
Collaborator

varshith257 commented Jun 20, 2024

@meetarora10 Can also give consistent space between the button and text in every navbar item?

@meetarora10
Copy link
Contributor Author

@varshith257 I will add more space then.

@meetarora10
Copy link
Contributor Author

Screenshot (493)

@meetarora10
Copy link
Contributor Author

@varshith257 please review and merge this PR so that I can create other issues and work on it.

@varshith257 varshith257 merged commit acf69c9 into Anishkagupta04:main Jun 21, 2024
7 checks passed
Copy link
Contributor

🎉 Your pull request has been successfully merged! 🎉 Thank you for your contribution to our project. Your efforts are greatly appreciated. Keep up the fantastic work! 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gssoc level2 medium (enhancements)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐞[Bug]: Navbar is not responsive
2 participants