Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Made the submit button functional #704

Merged
merged 1 commit into from
Jun 26, 2024

Conversation

samarsajad
Copy link
Contributor

Description

Added functionality to the submit button. When the submit button is clicked, it displays the messaged, "thank you for submitting your feedback" and refreshes. If the form is not filled and the submit button is clicked,it displays"Pease fill the feedback form "message

-## Closes #703

Type of PR

  • Bug fix
  • Feature enhancement
  • Documentation update
  • Other (specify): _______________

Screenshots / videos (if applicable)

[Attach any relevant screenshots or videos demonstrating the changes]

submit.button.fixed.mp4

Checklist

  • I have gone through the contributing guide
  • I have updated my branch and synced it with project main branch before making this PR
  • I have performed a self-review of my code
  • I have tested the changes thoroughly before submitting this pull request.
  • I have provided relevant issue numbers, screenshots, and videos after making the changes.
  • I have commented my code, particularly in hard-to-understand areas.

Additional context:

[Include any additional information or context that might be helpful for reviewers.]

Copy link

vercel bot commented Jun 25, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
rapidoc ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 25, 2024 8:16pm

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, @samarsajad! 🎉 Thank you for submitting your pull request. Your contribution is valuable and we appreciate your efforts to improve our project.We will promptly review your changes and offer feedback. Keep up the excellent work! Kindly remember to check our contributing guidelines

@samarsajad
Copy link
Contributor Author

Please review my pull request @varshith257 @Anishkagupta04

Copy link

netlify bot commented Jun 25, 2024

Deploy Preview for rapidoc ready!

Name Link
🔨 Latest commit 31f356e
🔍 Latest deploy log https://app.netlify.com/sites/rapidoc/deploys/667b2582ca203b000870314e
😎 Deploy Preview https://deploy-preview-704--rapidoc.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@varshith257
Copy link
Collaborator

@samarsajad Is emoji checking is needed?
If yes, you can put a case when !emojichecked to display user to check emoji

@samarsajad
Copy link
Contributor Author

samarsajad commented Jun 25, 2024

It's already there. Check the code in the files changed @varshith257 I didn't upload a demo of that cause the video needs to be short for uploading

@samarsajad
Copy link
Contributor Author

samarsajad commented Jun 25, 2024

@varshith257 Here is the code snippet that does what you requested Screenshot_2024-06-26-02-49-21-93_320a9a695de7cdce83ed5281148d6f19.jpg

@varshith257 varshith257 added gssoc level2 medium (enhancements) labels Jun 26, 2024
@varshith257 varshith257 merged commit ea0ad61 into Anishkagupta04:main Jun 26, 2024
9 checks passed
Copy link
Contributor

🎉 Your pull request has been successfully merged! 🎉 Thank you for your contribution to our project. Your efforts are greatly appreciated. Keep up the fantastic work! 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gssoc level2 medium (enhancements)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐞[Bug]: Submit button is not functional
2 participants