Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solves Issue No. 728- Unneccesary redirecting to a seperate 'Rate us' and 'Contact Us' + Routing of the navbar. #770

Merged
merged 10 commits into from
Jul 7, 2024

Conversation

Nidhi-Satyapriya
Copy link
Contributor

@Nidhi-Satyapriya Nidhi-Satyapriya commented Jul 5, 2024

Description

I made the following corrections:-

  1. On clicking "Rate Us" and "Contact Us", the control directs to their respective sections, ensuring consistency of the website.
  2. Introduced a confirmatory message in "#contact" section (disappears after 5secs) + beautified css in the same.
  3. Added a page named "med.html". It serves as the order portal of the "service" tab.
  4. Proper Routing from "news.html" ,"service.html" and "Doctor Experience.html" to rest of the pages and sections.
  5. Proper routing from the footer of all the pages.
  6. Introduced smooth scrolling to the different sections of the page, feature enhancement.
  7. Removed the "rateus.html" and "contact.html" , since its utility was already satisfied.

Related Issues

Solves Issue No. 728- Unneccesary redirecting to a seperate 'Rate us' and 'Contact Us' + Routing of the navbar.

Type of PR

  • Bug fix
  • Feature enhancement
  • Documentation update
  • Other (specify): _______________

Screenshots / videos (if applicable)

https://github.com/Anishkagupta04/RAPIDOC-HEALTHCARE-WEBSITE-/assets/123321320/072c852d-14fa-43eb-bf26-a2f9b273da87
[Maps works fine. Network problem here].

  1. Scrolls down to the respective sections.
  2. On dropping a msg, displays a confirmatory message too.

Checklist

  • I have gone through the contributing guide
  • I have updated my branch and synced it with project main branch before making this PR
  • I have performed a self-review of my code
  • I have tested the changes thoroughly before submitting this pull request.
  • I have provided relevant issue numbers, screenshots, and videos after making the changes.
  • I have commented my code, particularly in hard-to-understand areas.

Additional context:

I noticed that there are still some pages left to be created to be linked to the footer. Eg- Testimonials. Users looking for creating issues can work on this.

Copy link

vercel bot commented Jul 5, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
rapidoc ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 7, 2024 7:02am

Copy link

netlify bot commented Jul 5, 2024

Deploy Preview for rapidoc ready!

Name Link
🔨 Latest commit 4739700
🔍 Latest deploy log https://app.netlify.com/sites/rapidoc/deploys/668a3d8e605d70000835d1f0
😎 Deploy Preview https://deploy-preview-770--rapidoc.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, @Nidhi-Satyapriya! 🎉 Thank you for submitting your pull request. Your contribution is valuable and we appreciate your efforts to improve our project.We will promptly review your changes and offer feedback. Keep up the excellent work! Kindly remember to check our contributing guidelines

@varshith257
Copy link
Collaborator

@Nidhi-Satyapriya Contact us link in the navbar has been broken:

image

@Nidhi-Satyapriya
Copy link
Contributor Author

@varshith257 yes, happened while solving merge conflicts. I resolved it. Would you check once?

@varshith257 varshith257 added gssoc level2 medium (enhancements) labels Jul 6, 2024
med.html Show resolved Hide resolved
@Nidhi-Satyapriya
Copy link
Contributor Author

Sir, is my job done and the issue is closed or I need to look over it once again? @varshith257

@varshith257
Copy link
Collaborator

@Nidhi-Satyapriya Please resolve conflicts and LGTM

@Nidhi-Satyapriya
Copy link
Contributor Author

Nidhi-Satyapriya commented Jul 7, 2024

@varshith257 I just resolved the conflicts. You may now review this.

Html-Files/news.html Outdated Show resolved Hide resolved
@varshith257 varshith257 merged commit ea43a82 into Anishkagupta04:main Jul 7, 2024
7 checks passed
Copy link
Contributor

github-actions bot commented Jul 7, 2024

🎉 Your pull request has been successfully merged! 🎉 Thank you for your contribution to our project. Your efforts are greatly appreciated. Keep up the fantastic work! 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gssoc level2 medium (enhancements)
Projects
None yet
2 participants