Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed login and username #797

Closed
wants to merge 10 commits into from

Conversation

Subhams-GIT
Copy link

Description

  1. fixed login where without signup login was sucessfull.
  2. fixed username.
  3. added expiry time.

Related Issues

[Cite any related issue(s) this pull request addresses. If none, simply state “None”]

Type of PR

  • [*] Bug fix
  • [*] Feature enhancement
  • Documentation update
  • Other (specify): _______________

Screenshots / videos (if applicable)

[Attach any relevant screenshots or videos demonstrating the changes]
Screenshot (361)
Screenshot (360)
Screenshot (359)
Screenshot (358)

-[*] I have gone through the contributing guide

  • [* ] I have updated my branch and synced it with project main branch before making this PR
  • [* ] I have performed a self-review of my code
  • [* ] I have tested the changes thoroughly before submitting this pull request.
  • [ *] I have provided relevant issue numbers, screenshots, and videos after making the changes.
  • I have commented my code, particularly in hard-to-understand areas.

Additional context:

[Include any additional information or context that might be helpful for reviewers.]
firebase config needs to be changed
Screenshot 2024-07-08 221804

Copy link

vercel bot commented Jul 8, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
rapidoc ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 28, 2024 9:34am

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, @Subhams-GIT! 🎉 Thank you for submitting your pull request. Your contribution is valuable and we appreciate your efforts to improve our project.We will promptly review your changes and offer feedback. Keep up the excellent work! Kindly remember to check our contributing guidelines

Copy link

netlify bot commented Jul 8, 2024

Deploy Preview for rapidoc ready!

Name Link
🔨 Latest commit 7b6d16c
🔍 Latest deploy log https://app.netlify.com/sites/rapidoc/deploys/66a610a2fa53ee000843761f
😎 Deploy Preview https://deploy-preview-797--rapidoc.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Subhams-GIT
Copy link
Author

Subhams-GIT commented Jul 10, 2024

Pls review this asap either there will be again merge conflicts.
Can you make it level 2 as I have fixed more issues simultaneously.

@varshith257
Copy link
Collaborator

@Subhams-GIT Can you fix the merge conflicts and tag me?

@varshith257 varshith257 added gssoc level2 medium (enhancements) labels Jul 25, 2024
@Subhams-GIT
Copy link
Author

Sure but pls review it else ther would be again conflicts

@varshith257
Copy link
Collaborator

Ok fix conflicts and tag me

@Subhams-GIT
Copy link
Author

@varshith257 pls check this

@varshith257
Copy link
Collaborator

@Subhams-GIT Can you tag me after fixing conflicts?

@Subhams-GIT Subhams-GIT closed this Sep 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gssoc level2 medium (enhancements)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐞[Bug]: without account creation login is sucessfull
2 participants