Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Footer in Terms and Condition Page #840

Closed

Conversation

RadhikaMalpani1702
Copy link
Contributor

Description

Hey @Anishkagupta04 and @varshith257

I have Added Footer in Terms and Condition Page

Related Issues

Type of PR

  • Bug fix
  • Feature enhancement
  • Documentation update
  • Other (specify): _______________

Screenshots / videos (if applicable)

image

foot.mp4

Checklist

  • I have gone through the contributing guide
  • I have updated my branch and synced it with project main branch before making this PR
  • I have performed a self-review of my code
  • I have tested the changes thoroughly before submitting this pull request.
  • I have provided relevant issue numbers, screenshots, and videos after making the changes.
  • I have commented my code, particularly in hard-to-understand areas.

Additional context:

[Include any additional information or context that might be helpful for reviewers.]

Copy link

vercel bot commented Jul 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
rapidoc ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 29, 2024 1:42pm

Copy link

netlify bot commented Jul 12, 2024

Deploy Preview for rapidoc ready!

Name Link
🔨 Latest commit 2c8ded6
🔍 Latest deploy log https://app.netlify.com/sites/rapidoc/deploys/66a79c28cf676700084020c5
😎 Deploy Preview https://deploy-preview-840--rapidoc.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, @RadhikaMalpani1702! 🎉 Thank you for submitting your pull request. Your contribution is valuable and we appreciate your efforts to improve our project.We will promptly review your changes and offer feedback. Keep up the excellent work! Kindly remember to check our contributing guidelines

@RadhikaMalpani1702
Copy link
Contributor Author

@varshith257 Please merge this PR as i need this point to score in leaderboard

@RadhikaMalpani1702
Copy link
Contributor Author

@varshith257 Can you please merge it

@varshith257
Copy link
Collaborator

@Pruthaa17 @Anjaliavv51 @aditya-bhaumik Have a look at this PR

@Anjaliavv51
Copy link
Contributor

Anjaliavv51 commented Jul 18, 2024

@varshith257 this PR can be merged , all changes meantioned by her are done , check the below screenshoot.

@varshith257
Copy link
Collaborator

@Anjaliavv51 Is it good with alignment and I can't see the navbar and some gaps before footer of page in deploy preview from mobile

@aditya-bhaumik
Copy link
Contributor

@RadhikaMalpani1702 please add the navbar in the page also

@Anjaliavv51
Copy link
Contributor

@RadhikaMalpani1702 their is missing of social icons.

image

Add also change the favicon of the webapage to rd.png image in images folder.

image

And also minimize the space above footer

image

Make sure the header and footer matches , in font ,color and size.

@Anjaliavv51
Copy link
Contributor

@varshith257 those are the changes that should be done by @RadhikaMalpani1702

@Anjaliavv51
Copy link
Contributor

@RadhikaMalpani1702 please view the above changes.

@varshith257
Copy link
Collaborator

@RadhikaMalpani1702 Looks good to merge and update with social icons

@varshith257
Copy link
Collaborator

@RadhikaMalpani1702 Can you align footer with latest changes done in home page footer and tag me to get quick attention to merge this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐞[Bug]: Add Footer and Navbar in the Terms and Condition Page
4 participants