Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed overlapping #877

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

samarsajad
Copy link
Contributor

Description

Fixed overlapping of the services page

Related Issues

[Cite any related issue(s) this pull request addresses. If none, simply state “None”]

Type of PR

  • Bug fix
  • Feature enhancement
  • Documentation update
  • Other (specify): _______________

Screenshots / videos (if applicable)

image

Checklist

  • I have gone through the contributing guide
  • I have updated my branch and synced it with project main branch before making this PR
  • I have performed a self-review of my code
  • I have tested the changes thoroughly before submitting this pull request.
  • I have provided relevant issue numbers, screenshots, and videos after making the changes.
  • I have commented my code, particularly in hard-to-understand areas.

Additional context:

[Include any additional information or context that might be helpful for reviewers.]

Copy link

vercel bot commented Jul 15, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
rapidoc ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 16, 2024 6:15pm

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, @samarsajad! 🎉 Thank you for submitting your pull request. Your contribution is valuable and we appreciate your efforts to improve our project.We will promptly review your changes and offer feedback. Keep up the excellent work! Kindly remember to check our contributing guidelines

Copy link

netlify bot commented Jul 15, 2024

Deploy Preview for rapidoc ready!

Name Link
🔨 Latest commit 659e5b9
🔍 Latest deploy log https://app.netlify.com/sites/rapidoc/deploys/6696b8d903a6d400096d2619
😎 Deploy Preview https://deploy-preview-877--rapidoc.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@samarsajad
Copy link
Contributor Author

Please review my pull request so that I can work on the issue #845 which is related to this page @varshith257 @Anishkagupta04

@varshith257
Copy link
Collaborator

Is there any large gap after first section to second section in service page?

@samarsajad
Copy link
Contributor Author

Is there any large gap after first section to second section in service page?

I don't think so. I just checked the deploy preview it looks as expected. However if you want changed you can let me know @varshith257

@varshith257
Copy link
Collaborator

Is home also got misaligned? I am viewing it in mobile can't able to understand what happened

@samarsajad
Copy link
Contributor Author

Is home also got misaligned? I am viewing it in mobile can't able to understand what happened

No the homepage is fine. @varshith257

@varshith257
Copy link
Collaborator

Ok, will review this PR later as code changes are more

@samarsajad
Copy link
Contributor Author

samarsajad commented Jul 16, 2024

Ok, will review this PR later as code changes are more

Okay thank you so much. I've many open pull requests in this repo. If you get time please review them too #869 & #842 @varshith257

Copy link
Contributor

This issue has been marked as stale because it has been inactive for more than 7 days. It will be closed if no further activity occurs in the next 10 days. Please update if you want to keep it open.

@github-actions github-actions bot added the stale label Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐞[Bug]: The service section is overlapping
2 participants