Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Made "Blood Test" Page Responsive #900

Merged
merged 25 commits into from
Jul 29, 2024
Merged

Conversation

MastanSayyad
Copy link
Contributor

@MastanSayyad MastanSayyad commented Jul 16, 2024

Description

Hey @varshith257 issue #894

I have made the blood test page responsive (you can redirect to /test.html)

Before

image

image

After

image

image

image

Screenrecord

test.html.mp4

Type of PR

  • Bug fix

Checklist

  • I have gone through the contributing guide
  • I have updated my branch and synced it with project main branch before making this PR
  • I have performed a self-review of my code
  • I have tested the changes thoroughly before submitting this pull request.
  • I have provided relevant issue numbers, screenshots, and videos after making the changes.
  • I have commented my code, particularly in hard-to-understand areas.

Copy link

vercel bot commented Jul 16, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
rapidoc ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 29, 2024 4:16am

Copy link

netlify bot commented Jul 16, 2024

Deploy Preview for rapidoc ready!

Name Link
🔨 Latest commit 24d29d0
🔍 Latest deploy log https://app.netlify.com/sites/rapidoc/deploys/66a7177c7d714500084662c2
😎 Deploy Preview https://deploy-preview-900--rapidoc.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, @MastanSayyad! 🎉 Thank you for submitting your pull request. Your contribution is valuable and we appreciate your efforts to improve our project.We will promptly review your changes and offer feedback. Keep up the excellent work! Kindly remember to check our contributing guidelines

@varshith257
Copy link
Collaborator

@MastanSayyad Can the navbar align with the left and also need to update rapidoc logo with the text? @Anjaliavv51 @aditya-bhaumik Guide, through this recently merged Prs of you.

approve/request changes

@MastanSayyad
Copy link
Contributor Author

@varshith257 understood!

@Anjaliavv51
Copy link
Contributor

@MastanSayyad make the nav bar in small screen according to the below and place the logo as below inside the nav bar.

image

image

@Anjaliavv51
Copy link
Contributor

@MastanSayyad after changes , please resolve the conflicts too.

@varshith257
Copy link
Collaborator

@MastanSayyad Also ensure the logo is replaced by text in navbar of how other prs of same issue added

@Anjaliavv51
Copy link
Contributor

@MastanSayyad but in your code changes preview , their is no any view of navbar hamburger and footer social icons size is large.

Screenshot_20240728_125327_Chrome.jpg

Screenshot_20240728_125331_Chrome.jpg

@MastanSayyad
Copy link
Contributor Author

@MastanSayyad but in your code changes preview , their is no any view of navbar hamburger and footer social icons size is large.

Screenshot_20240728_125327_Chrome.jpg

Screenshot_20240728_125331_Chrome.jpg

It's because I have merged and updated the latest branch

@Anjaliavv51
Copy link
Contributor

@MastanSayyad sorry I didn't get u?

@MastanSayyad
Copy link
Contributor Author

@MastanSayyad sorry I didn't get u?

I mean In preview the changes are due to latest branch updates (there are no changes of mine yet as i didnt commit/push the changes)

@Anjaliavv51
Copy link
Contributor

@MastanSayyad sorry I didn't get u?

I mean In preview the changes are due to latest branch updates (there are no changes of mine yet as i didnt commit/push the changes)

Okay then ,pls commit the changes.

@MastanSayyad
Copy link
Contributor Author

Wait, I'm fixing the broken code, almost finished!

test.html Fixed Show fixed Hide fixed
@MastanSayyad
Copy link
Contributor Author

Hey @varshith257 I have fixed everything the page is now fully responsive

image

image

image

Screen Record

28.07.2024_14.30.52_REC.mp4

@MastanSayyad
Copy link
Contributor Author

Hey @varshith257 @Anjaliavv51 @aditya-bhaumik review it, the page is responsive now!

Copy link
Contributor

@Anjaliavv51 Anjaliavv51 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved.

@Anjaliavv51
Copy link
Contributor

@varshith257 changes are great merge the PR.

@MastanSayyad
Copy link
Contributor Author

@varshith257 pls merge this PR

@varshith257
Copy link
Collaborator

@MastanSayyad Can you also align navbar elements? I can see they are misaligned in the navbar

@MastanSayyad
Copy link
Contributor Author

MastanSayyad commented Jul 29, 2024

@MastanSayyad Can you also align navbar elements? I can see they are misaligned in the navbar

@varshith257 It's done now!

image

Copy link
Contributor

@Anjaliavv51 Anjaliavv51 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved
@MastanSayyad Done a Great Job!

@Anjaliavv51
Copy link
Contributor

@varshith257 changes are great it can be merged.

@varshith257 varshith257 merged commit 5b37b06 into Anishkagupta04:main Jul 29, 2024
7 checks passed
Copy link
Contributor

🎉 Your pull request has been successfully merged! 🎉 Thank you for your contribution to our project. Your efforts are greatly appreciated. Keep up the fantastic work! 🚀

@varshith257
Copy link
Collaborator

Thanks @MastanSayyad and @Anjaliavv51 for following up on this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gssoc level3 hard (new feature)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants