-
Notifications
You must be signed in to change notification settings - Fork 256
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Made "Blood Test" Page Responsive #900
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
✅ Deploy Preview for rapidoc ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job, @MastanSayyad! 🎉 Thank you for submitting your pull request. Your contribution is valuable and we appreciate your efforts to improve our project.We will promptly review your changes and offer feedback. Keep up the excellent work! Kindly remember to check our contributing guidelines
@MastanSayyad Can the navbar align with the left and also need to update rapidoc logo with the text? @Anjaliavv51 @aditya-bhaumik Guide, through this recently merged Prs of you. approve/request changes |
@varshith257 understood! |
@MastanSayyad make the nav bar in small screen according to the below and place the logo as below inside the nav bar. |
@MastanSayyad after changes , please resolve the conflicts too. |
@MastanSayyad Also ensure the logo is replaced by text in navbar of how other prs of same issue added |
@MastanSayyad but in your code changes preview , their is no any view of navbar hamburger and footer social icons size is large. |
It's because I have merged and updated the latest branch |
@MastanSayyad sorry I didn't get u? |
I mean In preview the changes are due to latest branch updates (there are no changes of mine yet as i didnt commit/push the changes) |
Okay then ,pls commit the changes. |
Wait, I'm fixing the broken code, almost finished! |
Hey @varshith257 I have fixed everything the page is now fully responsive Screen Record28.07.2024_14.30.52_REC.mp4 |
Hey @varshith257 @Anjaliavv51 @aditya-bhaumik review it, the page is responsive now! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved.
@varshith257 changes are great merge the PR. |
@varshith257 pls merge this PR |
@MastanSayyad Can you also align navbar elements? I can see they are misaligned in the navbar |
@varshith257 It's done now! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved
@MastanSayyad Done a Great Job!
@varshith257 changes are great it can be merged. |
🎉 Your pull request has been successfully merged! 🎉 Thank you for your contribution to our project. Your efforts are greatly appreciated. Keep up the fantastic work! 🚀 |
Thanks @MastanSayyad and @Anjaliavv51 for following up on this |
Description
Hey @varshith257 issue #894
I have made the blood test page responsive (you can redirect to /test.html)
Before
After
Screenrecord
test.html.mp4
Type of PR
Checklist
main
branch before making this PR