Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

made service page responsive #962

Closed
wants to merge 19 commits into from

Conversation

samarsajad
Copy link
Contributor

Description

Added media queries to make the services page mobile responsive.

Related Issues

Type of PR

  • Bug fix
  • Feature enhancement
  • Documentation update
  • Other (specify): _______________

Screenshots / videos (if applicable)

image

Checklist

  • I have gone through the contributing guide
  • I have updated my branch and synced it with project main branch before making this PR
  • I have performed a self-review of my code
  • I have tested the changes thoroughly before submitting this pull request.
  • I have provided relevant issue numbers, screenshots, and videos after making the changes.
  • I have commented my code, particularly in hard-to-understand areas.

Additional context:

[Include any additional information or context that might be helpful for reviewers.]

Copy link

vercel bot commented Jul 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
rapidoc ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 7, 2024 9:50pm

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, @samarsajad! 🎉 Thank you for submitting your pull request. Your contribution is valuable and we appreciate your efforts to improve our project.We will promptly review your changes and offer feedback. Keep up the excellent work! Kindly remember to check our contributing guidelines

@samarsajad
Copy link
Contributor Author

Please review my pull request @varshith257 @Anishkagupta04

Copy link

netlify bot commented Jul 22, 2024

Deploy Preview for rapidoc ready!

Name Link
🔨 Latest commit f197337
🔍 Latest deploy log https://app.netlify.com/sites/rapidoc/deploys/66b3ebfb2f090a00085daccc
😎 Deploy Preview https://deploy-preview-962--rapidoc.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@samarsajad
Copy link
Contributor Author

Please review my pull request @varshith257

@varshith257 varshith257 added gssoc level3 hard (new feature) labels Jul 26, 2024
@varshith257
Copy link
Collaborator

@samarsajad Can you fix this?

image

@samarsajad
Copy link
Contributor Author

samarsajad commented Jul 26, 2024

@samarsajad Can you fix this?

image
Where is it? It's not in mobile or tablet view. @varshith257

@varshith257
Copy link
Collaborator

I can see it in the deploy

@samarsajad
Copy link
Contributor Author

I can see it in the deploy

image
this is the ss from the deploy preview @varshith257 Only one find a doctor is showing

This reverts commit 04a365f.
@samarsajad
Copy link
Contributor Author

Please review the changes made @varshith257

@varshith257
Copy link
Collaborator

Footer is totally misaligned with mobile responsive and some of buttons in service page also misaligned

@Anjaliavv51 Take a look
/approve or request changes

@Anjaliavv51
Copy link
Contributor

@samarsajad footer alignment is not good , pls modify it.

Screenshot_20240728_092653_Chrome.jpg

@Anjaliavv51
Copy link
Contributor

Anjaliavv51 commented Jul 28, 2024

@samarsajad also , to check ur code output , please review the deployment in netlify

In below pic deploy preview

Screenshot_20240728_092800_GitHub.jpg

<script src="https://code.jquery.com/jquery-3.5.1.slim.min.js"></script>
<script src="https://cdn.jsdelivr.net/npm/@popperjs/core@2.5.4/dist/umd/popper.min.js"></script>
<script src="https://stackpath.bootstrapcdn.com/bootstrap/4.5.2/js/bootstrap.min.js"></script>

Check warning

Code scanning / CodeQL

Inclusion of functionality from an untrusted source Medium

Script loaded from content delivery network with no integrity check.

<!-- Bootstrap JS and dependencies -->

<script src="https://code.jquery.com/jquery-3.5.1.slim.min.js"></script>

Check warning

Code scanning / CodeQL

Inclusion of functionality from an untrusted source Medium

Script loaded from content delivery network with no integrity check.
@@ -28,6 +28,7 @@
href="https://cdnjs.cloudflare.com/ajax/libs/font-awesome/6.5.1/css/all.min.css"
/>
<link href="https://fonts.googleapis.com/css2?family=Poppins:ital,wght@0,100;0,200;0,300;0,400;0,500;0,600;0,700;0,800;0,900;1,100;1,200;1,300;1,400;1,500;1,600;1,700;1,800;1,900&display=swap" rel="stylesheet">
<script src="https://cdnjs.cloudflare.com/ajax/libs/html2pdf.js/0.9.2/html2pdf.bundle.min.js"></script>

Check warning

Code scanning / CodeQL

Inclusion of functionality from an untrusted source Medium

Script loaded from content delivery network with no integrity check.
const emoji = gif.getAttribute('data-emoji');
const gifSrc = gif.getAttribute('data-gif-src');
selectedEmojiElement.textContent = emoji;
selectedGifElement.src = gifSrc;

Check warning

Code scanning / CodeQL

DOM text reinterpreted as HTML Medium

DOM text
is reinterpreted as HTML without escaping meta-characters.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gssoc level3 hard (new feature)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐞[Bug]: Service page is not mobile responsive
3 participants