Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add path #505

Merged
merged 1 commit into from
Oct 9, 2024
Merged

Add path #505

merged 1 commit into from
Oct 9, 2024

Conversation

Isaac-Flath
Copy link
Contributor


name: Pull Request
about: Propose changes to the codebase
title: '[PR] '
labels: ''
assignees: ''


Related Issue
#503

Proposed Changes

  • Add path argument to HTMX function to allow you to load a specific path in the jupyter Iframe.

Types of changes
What types of changes does your code introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist
Go over all the following points, and put an x in all the boxes that apply:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I am aware that this is an nbdev project, and I have edited, cleaned, and synced the source notebooks instead of editing .py or .md files directly.

Additional Information
Screenshot of it working
Screenshot 2024-10-08 at 7 18 01 PM

@Isaac-Flath Isaac-Flath added the enhancement New feature or request label Oct 8, 2024
@Isaac-Flath Isaac-Flath requested a review from jph00 October 8, 2024 23:58
Copy link

gitnotebooks bot commented Oct 8, 2024

Found 1 changed notebook. Review the changes at https://app.gitnotebooks.com/AnswerDotAI/fasthtml/pull/505

@jph00
Copy link
Contributor

jph00 commented Oct 9, 2024

That was quick! :D

@jph00 jph00 merged commit 82ec504 into main Oct 9, 2024
2 checks passed
@jph00 jph00 deleted the JupyHTMX branch October 9, 2024 00:41
@Isaac-Flath Isaac-Flath restored the JupyHTMX branch October 10, 2024 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants