Oresim update #307
Merged
Oresim update #307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updated oresim to 1.20.2
Related Issue
Motivation and Context
Oresim used to have a config that tracked ore generation differences over multiple versions.
This update changes it to just use the same generation that the current client does.
Why?
The advantage is that I don't have to keep updating the config to new minecraft versions.
More mixins means that there is potentially more effort to porting the addon as a whole but debugging the oresim config is the bigger pain.
The disadvantage is that oresim won't work in older worlds anymore.
How Has This Been Tested?
I tested the full functionality of the module in singleplayer and in multiplayer
Screenshots (if appropriate):
Types of changes