Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Longus colli neck muscles #28

Merged
merged 2 commits into from
Oct 10, 2024
Merged

Conversation

Hamedshayestehpour
Copy link
Contributor

Longus colli neck muscles have been added to AMMR4

@divyaksh-chander
Copy link
Contributor

I will just add some comments:

  • The reference nodes in the existing muscles (like longus capitis) are reused for making the new muscles (like superior obliques). This is a fair assumption, given that we are really working on very small bones and surfaces.
  • The longus colli superior and inferior obliques don't have any via points or wrapping surfaces. The muscle path will not be realistic in large angles at the neck, where it would need some wrapping surface or such. This has not been done at the moment and could be a future improvement.

@melund
Copy link
Member

melund commented Oct 10, 2024

@Hamedshayestehpour Remember to also make a PR with the muscle parameter fixes for the AMMR-data repo. 👍

@melund melund merged commit dbe3283 into ammr4-beta Oct 10, 2024
26 checks passed
@melund melund deleted the LongusColli_NeckMuscles branch October 10, 2024 06:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants