Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update eth-account and hexbytes #52

Closed
wants to merge 3 commits into from

Conversation

DanielSchiavini
Copy link
Contributor

@DanielSchiavini DanielSchiavini commented May 21, 2024

This PR updates eth-account. Note that this version has a few breaking changes that are not used in this project.

What I did

  • Updated eth-account
  • Updated hexbytes (dependency of eth-account)

How I did it

Updating the requirements in setup.py

How to verify it

Tests should still pass

Checklist

  • Passes all linting checks (pre-commit and CI jobs)
  • New test cases have been added and are passing
  • Documentation has been updated
  • PR title follows

fubuloubu
fubuloubu previously approved these changes May 21, 2024
Copy link
Member

@fubuloubu fubuloubu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have to verify this update upstream to Ape to see if it should be a patch or minor breaking change

fubuloubu
fubuloubu previously approved these changes May 21, 2024
tests/test_common.py Outdated Show resolved Hide resolved
DanielSchiavini added a commit to curvefi/twocrypto-ng that referenced this pull request May 22, 2024
dependency conflict being fixed in ApeWorX/eip712#52
@antazoey
Copy link
Member

Have to verify this update upstream to Ape to see if it should be a patch or minor breaking change

I dont think Ape would be able to download this yet, until web3.py 7.0 is released, but I could be wrong.

@antazoey
Copy link
Member

some parallels #45

@fubuloubu
Copy link
Member

@DanielSchiavini we are merging and releasing #45, please rebase your work off of that (if some changes are still available)

We can then release a minor breaking change

@DanielSchiavini
Copy link
Contributor Author

@fubuloubu I don't think there's anything left after #45. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants