generated from ApeWorX/project-template
-
-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: add data acquisition to recorders #64
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
sorry that there are a lot of inter-related changes here, things were very tied together before. I somewhat refactored them to be less codependent |
also refactor result handling
mikeshultz
reviewed
May 2, 2024
mikeshultz
reviewed
May 2, 2024
mikeshultz
reviewed
May 2, 2024
mikeshultz
reviewed
May 2, 2024
mikeshultz
approved these changes
May 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Refactors the structure of
HandlerResult
to add support for serialized data structures for metricsMakes a breaking change deprecating
SQLiteRecorder
in favor ofJSONLineRecorder
Makes a breaking change to annotated Worker state and App state
Makes a larger refactor of
BaseRunner.run
startup sequence to reduce errant errors and give better loggingAdds a callback to allow configuring a recorder in
silverback run
command, and pipes that toBaseRunner
related: #59
requires: #63, #66 (for proper labeling of results)How I did it
How to verify it
Checklist