Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: add data acquisition to recorders #64

Merged
merged 28 commits into from
May 2, 2024
Merged

feat!: add data acquisition to recorders #64

merged 28 commits into from
May 2, 2024

Conversation

fubuloubu
Copy link
Member

@fubuloubu fubuloubu commented Apr 2, 2024

What I did

Refactors the structure of HandlerResult to add support for serialized data structures for metrics

Makes a breaking change deprecating SQLiteRecorder in favor of JSONLineRecorder

Makes a breaking change to annotated Worker state and App state

Makes a larger refactor of BaseRunner.run startup sequence to reduce errant errors and give better logging

Adds a callback to allow configuring a recorder in silverback run command, and pipes that to BaseRunner

related: #59

requires: #63, #66 (for proper labeling of results)

How I did it

How to verify it

Checklist

  • Passes all linting checks (pre-commit and CI jobs)
  • New test cases have been added and are passing
  • Documentation has been updated
  • PR title follows Conventional Commit standard (will be automatically included in the changelog)

@fubuloubu fubuloubu mentioned this pull request Apr 9, 2024
2 tasks
@fubuloubu fubuloubu marked this pull request as ready for review April 17, 2024 02:58
@fubuloubu
Copy link
Member Author

sorry that there are a lot of inter-related changes here, things were very tied together before. I somewhat refactored them to be less codependent

@fubuloubu fubuloubu mentioned this pull request Apr 17, 2024
4 tasks
silverback/recorder.py Outdated Show resolved Hide resolved
silverback/application.py Outdated Show resolved Hide resolved
@fubuloubu fubuloubu enabled auto-merge (squash) May 2, 2024 21:33
@fubuloubu fubuloubu merged commit ced902d into main May 2, 2024
18 checks passed
@fubuloubu fubuloubu deleted the feat/add-daq branch May 2, 2024 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants