Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add corenlp provider microservice #259

Merged
merged 33 commits into from
Aug 29, 2023
Merged

Add corenlp provider microservice #259

merged 33 commits into from
Aug 29, 2023

Conversation

Laxraa
Copy link
Collaborator

@Laxraa Laxraa commented Aug 14, 2023

No description provided.

Laxraa and others added 19 commits June 12, 2023 16:37
@Laxraa
changed structure of CoreNLPProvider: now possible to add CoreNLPProv…
9ff21cd 
…ider that sends requests to microservice
@Laxraa
added textprovider-json dependency
c142648
@Laxraa
implemented TextProcessorService
775f172
@Laxraa
added config
4a724f8
@Laxraa
refactored ConfigManager
f568d62
@Laxraa
added health check for service
6208ad9
@Laxraa
added url encoding and changed filepath of config file
fb8dd82
@Laxraa
added javadoc
5045fd5
@Laxraa
add MicroserviceChecker
7c75e80
@Laxraa
removed TextProcessorFactory.java and added logger
06bc011
@Laxraa
add authenticated microservice requests
c6b82dd
@Laxraa
update MicroserviceChecker
563906f
@Laxraa
update version of textprovider-json
c7c65bc
@Laxraa
update path of config.properties
0671bc7
@Laxraa
add usage of environment variables in ConfigManager
e5c0f2d
@Laxraa @github-actions
Apply formatting changes
a3f7411
@Laxraa
remove code smells
210ae2d
@Laxraa
Merge remote-tracking branch 'origin/feature/corenlp_provider_microse…
47a8ea6 
…rvice' into feature/corenlp_provider_microservice
@Laxraa @github-actions
Apply formatting changes
ceb2ba2
dfuchss
dfuchss reviewed Aug 14, 2023
View reviewed changes
Copy link
Member

@dfuchss dfuchss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments

...el/mcse/ardoco/core/text/providers/informants/corenlp/textprocessor/MicroserviceChecker.java Outdated Show resolved Hide resolved
...t/kastel/mcse/ardoco/core/text/providers/informants/corenlp/textprocessor/TextProcessor.java Outdated Show resolved Hide resolved
...l/mcse/ardoco/core/text/providers/informants/corenlp/textprocessor/TextProcessorService.java Outdated Show resolved Hide resolved
@Laxraa Laxraa marked this pull request as ready for review August 28, 2023 16:45
@sonarcloud
Copy link

sonarcloud bot commented Aug 29, 2023 •
edited
Loading

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

48.1% 48.1% Coverage
0.0% 0.0% Duplication

@Gram21 Gram21 changed the title Feature/corenlp provider microservice Add corenlp provider microservice Aug 29, 2023
@Gram21 Gram21 merged commit bd75ecd into main Aug 29, 2023
9 checks passed
@Gram21 Gram21 deleted the feature/corenlp_provider_microservice branch August 29, 2023 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dfuchss dfuchss dfuchss left review comments

@Gram21 Gram21 Gram21 approved these changes

@Hossiphi Hossiphi Awaiting requested review from Hossiphi Hossiphi is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Laxraa @Gram21 @dfuchss