Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: Move textprovider json from other repo to core #263

Merged
merged 138 commits into from
Aug 30, 2023
Merged

Feature: Move textprovider json from other repo to core #263

merged 138 commits into from
Aug 30, 2023

Conversation

dfuchss
Copy link
Member

@dfuchss dfuchss commented Aug 29, 2023 •
edited
Loading

This PR moves the code of https://github.com/ArDoCo/textprovider-json to the core repository by maintaining the history of the project.

TODOs:

  • Fix README
  • Link in JSON anpassen

Gram21 and others added 30 commits December 16, 2022 15:21
@Gram21
Initial commit
f850a65
@Gram21
Add initial schemas for tag-sets
0a8f93a
@Gram21
Add gitignore and gitattributes
0d639dc
@Gram21
Add word schema
921cace
@Gram21
Add sentence schema
abdafb1
@Gram21
Add text schema
369b62e
@Gram21
Update/Format word schema
cd9bb22
@Gram21
Remove PhraseType schema
3aaa29f
@Gram21
Create single file definition
dbf29f9 
Moved split schemas into own folder
@Gram21
Add definitions to avoid duplicated code
d739afc
@Gram21
Remove split definitions
5e33511
@Gram21
Add id to words
d930b73
@Gram21
Add example json file and update README
b02e7b6
@Gram21
Format example
94314d0
@Gram21
Update gitignore
7157995
@Gram21
add some (not fully functional) code
813f2bb
@Laxraa
added valid json example
8ecc4d7
@Laxraa
refactored folder structure
1da54ad
@Laxraa
added tests and networknt dependency
efbb525
@Laxraa
overwritten equals methods
145b09f
@Laxraa
pasted TextImpl, refactored package structure
7c47625
@Laxraa
added Text, Sentence, Word and Phrase Stubs
be3f44b
@Laxraa
renamed the text, sentence and word dtos
e5040ac
@Laxraa
first skeleton of dto converter
4c7ea5d
@Laxraa
refactored text, sentence and word impl
cc4beab
@Laxraa
started dto converter
bdc06b5
@Laxraa
added conversion of dto word
3186b4e
@Laxraa
added tree parser
4ae0c05
@Laxraa
added tree parser test
83ba58c
@Laxraa
added method convertToSentence
85de731
actions-user and others added 23 commits August 1, 2023 10:38
@actions-user
Auto-Update Dependencies
a971270 
Updating parent from 0.16.0 to 0.17.0
@actions-user
Release 0.7.0
4f06c98
@actions-user
Prepare for next development cycle
b8a49d3
@Laxraa
Feature/update schema (#7)
1dcdfa5 
The POSTag HYPH was missing and incoming/ outgoing dependencies are apparently not unique (e.g. when analyzing the text teastore, the 15th word of the 17th sentence has the same outgoing dependency two times).
Added some tests, too.

* added POSTag HYPH
* incoming and outgoing dependencies no longer unique
* add logger to json converter
* add NotConvertableException
* add InvalidJsonException
* add ConverterUtilTest
* add JsonConverterTest
* add DtoToObjectConverterTest
* updated DtoToObjectConverterTest
* add ObjectToDtoConverter
* rename dto objects
* Apply formatting changes

---------

Co-authored-by: Laxraa <Laxraa@users.noreply.github.com>
@actions-user
Auto-Update Dependencies
dce75d2 
Updating parent from 0.17.0 to 0.18.0
@actions-user
Release 0.8.0
4ececd1
@actions-user
Prepare for next development cycle
10afa6b
@actions-user
Auto-Update Dependencies
ac29beb 
Updating parent from 0.18.0 to 0.18.1
@actions-user
Release 0.9.0
0545632
@actions-user
Prepare for next development cycle
3be6f8c
@actions-user
Auto-Update Dependencies
1e7cecb 
Updating parent from 0.18.1 to 0.19.0
@actions-user
Release 0.10.0
d8137d3
@actions-user
Prepare for next development cycle
b5a4749
@dfuchss
Update ardoco.core.version
3090ada
@actions-user
Release 0.11.0
daf62fb
@actions-user
Prepare for next development cycle
ead59c0
@dfuchss
Add 'framework/textprovider-json/' from commit 'ead59c0924327207e2fec…
62ef188 
…17f15b0884a6e3a5df6'

git-subtree-dir: framework/textprovider-json
git-subtree-mainline: 717d282
git-subtree-split: ead59c0
@dfuchss
Migrate project to match structure in ardoco core
807a453
@Gram21
Merge branch 'main' into feature/textprovider-json
15e0536
@dfuchss
Fix README. Move Packages
16fa4f8
@dfuchss
Merge branch 'feature/textprovider-json' of github.com:ArDoCo/Core in…
501f494 
…to feature/textprovider-json
@dfuchss
Fix after merge
633d937
@dfuchss
Spelling in readme
19fb706
@dfuchss dfuchss marked this pull request as ready for review August 30, 2023 09:14
@dfuchss dfuchss requested a review from Laxraa August 30, 2023 09:14
@sonarcloud
Copy link

sonarcloud bot commented Aug 30, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
2.1% 2.1% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@dfuchss dfuchss merged commit a3c902b into main Aug 30, 2023
8 of 9 checks passed
@dfuchss dfuchss deleted the feature/textprovider-json branch August 30, 2023 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gram21 Gram21 Awaiting requested review from Gram21 Gram21 is a code owner

@Hossiphi Hossiphi Awaiting requested review from Hossiphi Hossiphi is a code owner

@Laxraa Laxraa Awaiting requested review from Laxraa

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dfuchss @Gram21 @Laxraa @actions-user