Fork merge: Diagram-Text tracelinks, Improvements to the MME detection capabilities #286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change tests-resources folder layout
Update README.md to prevent misunderstandings
As it turns out, array references in foreach loops are evaluated every cycle. Oops.
|
@menof36go after holiday / in the new year, could you resolve the conflicts ? :) The progress of this PR is good; soonish we hopefully can merge it :) |
|
@menof36go if you find some time please have a look at the PR :) We plan to adjust the architecture of ArDoCo soon and before that we want to merge the PR :) |
# Conflicts: # framework/common/pom.xml # framework/common/src/main/java/edu/kit/kastel/mcse/ardoco/core/api/diagramrecognition/Box.java # pom.xml # stages/diagram-recognition/src/main/kotlin/edu/kit/kastel/mcse/ardoco/lissa/DiagramRecognition.kt # stages/diagram-recognition/src/main/kotlin/edu/kit/kastel/mcse/ardoco/lissa/diagramrecognition/model/DiagramImpl.kt # stages/pom.xml
dfuchss
reviewed
Jan 17, 2024
framework/common/src/main/java/edu/kit/kastel/mcse/ardoco/core/api/diagramrecognition/Box.java
Outdated
Show resolved
Hide resolved
...rk/common/src/main/java/edu/kit/kastel/mcse/ardoco/core/api/models/arcotl/code/CodeItem.java
Show resolved
Hide resolved
.../main/java/edu/kit/kastel/mcse/ardoco/core/api/textextraction/NounMappingChangeListener.java
Show resolved
Hide resolved
...ain/java/edu/kit/kastel/mcse/ardoco/core/api/textextraction/PhraseMappingChangeListener.java
Show resolved
Hide resolved
...mmon/src/main/java/edu/kit/kastel/mcse/ardoco/core/api/textextraction/TextStateStrategy.java
Show resolved
Hide resolved
...n/java/edu/kit/kastel/mcse/ardoco/core/codetraceability/SamCodeTraceabilityLinkRecovery.java
Outdated
Show resolved
Hide resolved
# Conflicts: # stages/diagram-recognition/pom.xml
|
dfuchss
approved these changes
Feb 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes are the result of my thesis Entity Recognition in Software Documentation Using Trace Links to Informal Diagrams
The last merge with main was commit d653a13. Some integration tests will probably fail because of the minor global changes. Generally, a favorable change is observed for the metrics. However, a small worsening in a particular metric might fail the tests.
Please let me know about any changes I should perform or oversights (e.g. missing documentation of classes I created). Before the final merge (assuming this PR is approved), I will update to the latest commit on ArDoCo main. Due to the large amount of changed files, it is likely that I missed some stuff.
Best regards,
Fabian