-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Replace Legacy Architecture Model #301
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also upgrade to Java 21
dfuchss
force-pushed
the
feature/remove-legacy-sam
branch
from
November 27, 2023 15:26
cbf6df6
to
b644cdf
Compare
dfuchss
force-pushed
the
feature/remove-legacy-sam
branch
from
November 27, 2023 15:28
b644cdf
to
91c3f83
Compare
This PR also updates the Java version to 21. Can you then please update the information about the Java version in the wiki (I think) and all places where we mention it? Thanks! |
dfuchss
force-pushed
the
feature/remove-legacy-sam
branch
from
November 27, 2023 16:28
3d70380
to
11ae34e
Compare
dfuchss
force-pushed
the
feature/remove-legacy-sam
branch
from
November 28, 2023 13:59
40bc42a
to
1e00ae3
Compare
Gram21
approved these changes
Nov 29, 2023
...va/edu/kit/kastel/mcse/ardoco/core/models/connectors/generators/code/shell/ShellVisitor.java
Outdated
Show resolved
Hide resolved
SonarCloud Quality Gate failed. 0 Bugs 77.1% Coverage Catch issues before they fail your Quality Gate with our IDE extension SonarLint |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, ArDoCo uses two versions of SAMs. See #278
This PR deprecates one of them and removes the extractors of the old SAM.