-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added l2 single/batch timelock stage #223
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good, tho one integration test failure, not sure if it's related
src-ts/proposalPipeline.ts
Outdated
@@ -94,7 +96,7 @@ export class StageTracker extends EventEmitter { | |||
while (polling) { | |||
try { | |||
const status = await this.stage.status(); | |||
if (currentStatus !== status) { | |||
// if (currentStatus !== status) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
woops, good catch
src-ts/proposalStage.ts
Outdated
@@ -12,7 +12,7 @@ import { | |||
import { Outbox__factory } from "@arbitrum/sdk/dist/lib/abi/factories/Outbox__factory"; | |||
import { L2ToL1TxEvent as NitroL2ToL1TransactionEvent } from "@arbitrum/sdk/dist/lib/abi/ArbSys"; | |||
import { OutBoxTransactionExecutedEvent } from "@arbitrum/sdk/dist/lib/abi/Outbox"; | |||
import { TransactionReceipt } from "@ethersproject/providers"; | |||
import { Log, TransactionReceipt } from "@ethersproject/providers"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
unused
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated
src-ts/proposalStage.ts
Outdated
} from "../typechain-types"; | ||
import { Inbox__factory } from "@arbitrum/sdk/dist/lib/abi/factories/Inbox__factory"; | ||
import { RollupUserLogic__factory } from "@arbitrum/sdk/dist/lib/abi/factories/RollupUserLogic__factory"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
unused
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated
No description provided.