Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added l2 single/batch timelock stage #223

Merged
merged 25 commits into from
Nov 17, 2023
Merged

Added l2 single/batch timelock stage #223

merged 25 commits into from
Nov 17, 2023

Conversation

yahgwai
Copy link
Collaborator

@yahgwai yahgwai commented Nov 1, 2023

No description provided.

@yahgwai yahgwai requested review from DZGoldman and fredlacs November 1, 2023 16:56
Copy link
Collaborator

@DZGoldman DZGoldman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, tho one integration test failure, not sure if it's related

@yahgwai yahgwai requested a review from DZGoldman November 15, 2023 17:07
@@ -94,7 +96,7 @@ export class StageTracker extends EventEmitter {
while (polling) {
try {
const status = await this.stage.status();
if (currentStatus !== status) {
// if (currentStatus !== status) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

woops, good catch

@@ -12,7 +12,7 @@ import {
import { Outbox__factory } from "@arbitrum/sdk/dist/lib/abi/factories/Outbox__factory";
import { L2ToL1TxEvent as NitroL2ToL1TransactionEvent } from "@arbitrum/sdk/dist/lib/abi/ArbSys";
import { OutBoxTransactionExecutedEvent } from "@arbitrum/sdk/dist/lib/abi/Outbox";
import { TransactionReceipt } from "@ethersproject/providers";
import { Log, TransactionReceipt } from "@ethersproject/providers";
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unused

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated

} from "../typechain-types";
import { Inbox__factory } from "@arbitrum/sdk/dist/lib/abi/factories/Inbox__factory";
import { RollupUserLogic__factory } from "@arbitrum/sdk/dist/lib/abi/factories/RollupUserLogic__factory";
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unused

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated

@yahgwai yahgwai merged commit 5dbe92a into main Nov 17, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants