Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standalone Nova Fee Sweep Proposal #303

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

godzillaba
Copy link
Collaborator

@godzillaba godzillaba commented Jul 29, 2024

This script should be used to "patch" some future proposal by adding a call to the nova inbox to sweep ETH from the L1 Timelock alias

note that it leaves the salt unchanged

updated to create a standalone proposal

@godzillaba godzillaba marked this pull request as ready for review July 29, 2024 17:58
@godzillaba godzillaba requested a review from gzeoneth July 29, 2024 18:49
@godzillaba
Copy link
Collaborator Author

godzillaba commented Aug 15, 2024

forgot Daniel already made something for this #278

@gzeoneth
Copy link
Collaborator

forgot Daniel already made something for this #278

let's close that and use this PR instead as I already reviewed this haha

gzeoneth
gzeoneth previously approved these changes Jan 3, 2025
Copy link
Collaborator

@gzeoneth gzeoneth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@godzillaba godzillaba changed the title Script to add nova timelock alias sweep to an existing proposal Standalone Nova Fee Sweep Proposal Jan 3, 2025
@godzillaba godzillaba requested a review from gzeoneth January 3, 2025 14:49
@godzillaba godzillaba dismissed gzeoneth’s stale review January 3, 2025 14:51

The script now makes a standalone proposal

@godzillaba
Copy link
Collaborator Author

to review the diff easier

git restore --source 397983e . && git restore scripts/proposals/NovaFeeSweep/generate.ts && diff scripts/proposals/NovaFeeSweep/patchProposal.ts scripts/proposals/NovaFeeSweep/generate.ts

Copy link
Collaborator

@gzeoneth gzeoneth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants