AP_CANManager: use 32 bit timeout #28399
Merged
+9
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tested that DroneCAN peripherals and scripting CAN sensors still work properly on CubeOrange. |
tpwrules
force-pushed
the
pr/can-32bit-timeout
branch
from
09276e7
to
a8577ef
Compare
|
A note about safety: this doesn't change any of the arithmetic, just changes the types so that specifying a timeout of longer than 71 minutes is not possible. Nowhere that I could find calculates timeouts, they are always hardcoded, so this is safe. I did update a variable name to make clear that it's actually a 64 bit deadline instead of a timeout, but not the arithmetic. |
bugobliterator
approved these changes
Oct 16, 2024
Saves a few bytes. 71 minutes ought to be enough for anybody!
Saves a handful of bytes. 71 minutes ought to be enough for anybody!
Saves a handful of bytes. 71 minutes ought to be enough for anybody!
tpwrules
force-pushed
the
pr/can-32bit-timeout
branch
from
a8577ef
to
7d4dbda
Compare
tridge
approved these changes
Nov 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Saves a handful of bytes. 71 minutes ought to be enough for anybody!