-
Notifications
You must be signed in to change notification settings - Fork 17.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow simulation of more htan two GPS instances #28578
base: master
Are you sure you want to change the base?
Allow simulation of more htan two GPS instances #28578
Conversation
4cce4e9
to
dad086b
Compare
5c5cae6
to
139cbeb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
close!
libraries/SITL/SIM_GPS.cpp
Outdated
@@ -30,6 +30,105 @@ | |||
|
|||
#include <GCS_MAVLink/GCS.h> | |||
|
|||
namespace SITL { | |||
// user settable parameters for airspeed sensors |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cut&paste?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed
// @Description: Enabled GPS | ||
// @Values: 0:Disable, 1:Enable | ||
// @User: Advanced | ||
AP_GROUPINFO_FLAGS("ENABLE", 1, GPSParms, enabled, 0, AP_PARAM_FLAG_ENABLE), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
blank line in tables
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed
libraries/SITL/SIM_GPS.cpp
Outdated
// @Param: HDG | ||
// @DisplayName: GPS Heading | ||
// @Description: Enable GPS1 output of NMEA heading HDT sentence or UBLOX_RELPOSNED | ||
// @Values: 0:Disabled, 1:Enabled |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not boolean?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Documented
libraries/SITL/SITL.h
Outdated
@@ -155,6 +155,7 @@ class SIM { | |||
GPS_HEADING_HDT = 1, | |||
GPS_HEADING_THS = 2, | |||
GPS_HEADING_KSXT = 3, | |||
GPS_HEADING_BASE = 4, // nb. I'm guessing, this could be ROVER! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
needs documenting
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed this up - the enumeration name was correct.
need to take into account addition of (eg.) _X suffix for VECTOR3F parameters
139cbeb
to
e996079
Compare
Test with:
No parameter conversion is done.
Parameters are moved to a subclass
Tested on branch for this PR: #28581
New requirements for testing RTK moving baseline - you must specify which is your "other" GPS as well as what sort of moving baseline thing you are.