Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow simulation of more htan two GPS instances #28578

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

peterbarker
Copy link
Contributor

@peterbarker peterbarker commented Nov 11, 2024

Test with:

./Tools/autotest/sim_vehicle.py -v ArduPlane --gdb --debug --console  -A --serial5=sim:gps:3

No parameter conversion is done.

Parameters are moved to a subclass

Tested on branch for this PR: #28581

New requirements for testing RTK moving baseline - you must specify which is your "other" GPS as well as what sort of moving baseline thing you are.

@peterbarker peterbarker removed the WIP label Nov 11, 2024
@peterbarker peterbarker force-pushed the pr/sitl-gps-simulate-four branch 7 times, most recently from 5c5cae6 to 139cbeb Compare November 13, 2024 00:56
Copy link
Contributor

@tridge tridge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

close!

@@ -30,6 +30,105 @@

#include <GCS_MAVLink/GCS.h>

namespace SITL {
// user settable parameters for airspeed sensors
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cut&paste?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

// @Description: Enabled GPS
// @Values: 0:Disable, 1:Enable
// @User: Advanced
AP_GROUPINFO_FLAGS("ENABLE", 1, GPSParms, enabled, 0, AP_PARAM_FLAG_ENABLE),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

blank line in tables

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

// @Param: HDG
// @DisplayName: GPS Heading
// @Description: Enable GPS1 output of NMEA heading HDT sentence or UBLOX_RELPOSNED
// @Values: 0:Disabled, 1:Enabled
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not boolean?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Documented

@@ -155,6 +155,7 @@ class SIM {
GPS_HEADING_HDT = 1,
GPS_HEADING_THS = 2,
GPS_HEADING_KSXT = 3,
GPS_HEADING_BASE = 4, // nb. I'm guessing, this could be ROVER!
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

needs documenting

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed this up - the enumeration name was correct.

@tridge tridge removed the DevCallEU label Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants