Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AP_DDS: status topic to report RC failsafe with callback function #28607

Merged

Conversation

tizianofiorenzani
Copy link
Contributor

What Changed

Follow Up to #28337.

The Status topic is now populated with the function in_rc_failsafe(), which is implemented as virtual in the RC_Channel class.

Test

Tested in SITL: set the parameter SIM_RC_FAIL to 1 and then 0.
You should see the following texts on the GCS:

image

And the following result when the status topic is echoed with ros2 topic echo /ap/status

image

Copy link
Collaborator

@Ryanf55 Ryanf55 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice improvement. Thanks for getting this in.

Copy link
Contributor

@peterbarker peterbarker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@peterbarker peterbarker merged commit 86f2167 into ArduPilot:master Nov 14, 2024
99 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants