Remove an unused array #28632
Open
Remove an unused array #28632
+0
−21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Take a look at PR28643: #28643 If that is a more reasonable way to deal with these compiler warnings then I can close this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove unused array. This array was causing the following Qurt compiler warning:
In file included from ../../libraries/AP_RCProtocol/AP_RCProtocol_Backend.cpp:32:
../../libraries/AP_RCProtocol/spm_srxl.h:61:5: warning: array designators are a C99 extension [-Wc99-designator]
[SrxlDevType_None] = 0x00,
^~~~~~~~~~~~~~~~~~
1 warning generated.
That is pointing out that array designators are not part of the C++ standard. They aren't even part of the C99 standard, they are an extension. So, they probably shouldn't be used in ArduPilot. It turns out that that array isn't even used anywhere so I just deleted it.