Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

autotest: Added Copter Smart RTL repeat detection test #28920

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

MichelleRos
Copy link
Contributor

This test is to demonstrate a bug that was found in Copter's Smart RTL where if it's left in circle mode for a long time it apparently doesn't always detect the loop, so Smart RTL still runs out of space after a while.

Added as a disabled test, to be enabled by whoever fixes the bug.

Copy link
Contributor

@peterbarker peterbarker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

def SMART_RTL_Repeat(self):
'''Test whether Smart RTL catches the repeat'''
self.takeoff(alt_min=10, mode='GUIDED')
self.set_rc(3, 1500)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
self.set_rc(3, 1500)
self.hover()

... that could be useful if you're running a frame other than the default, boring one.

We don't do this in many places yet, and it doesnt' actually do anything but set it to 1500... but aspirationally...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants