Port #97 to ros2 #101
Merged
Port #97 to ros2 #101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Update class and parameter documentation. - Apply Gazebo code style (mainly removing cuddled braces). - Use snake case for SDF elements. - Remove the environment variable defaults. - Require mandatory fields are set in SDF. - Use sensor topic name as default for image topic. - Use sensor topic name as prefix for enable streaming topic. - Update class doc string. - Update gz message strings. - Ensure streaming stops / starts when requested. Signed-off-by: Rhys Mainwaring <rhys.mainwaring@me.com>
Signed-off-by: Rhys Mainwaring <rhys.mainwaring@me.com>
Signed-off-by: Rhys Mainwaring <rhys.mainwaring@me.com>
Signed-off-by: Rhys Mainwaring <rhys.mainwaring@me.com>
Signed-off-by: Rhys Mainwaring <rhys.mainwaring@me.com>
srmainwaring
force-pushed
the
prs/pr-port-97-to-ros
branch
from
93eaa07
to
e220800
Compare
srmainwaring
requested review from
Hwurzburg and
Ryanf55
and removed request for
Hwurzburg
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Port #97 to
ros2branch.Closes #98