Add protection for nulltpr crash in CameraZoomPlugin #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ryanf55
force-pushed
the
bugfix/camera-initialize-nullptr-crash
branch
from
966cfe1
to
5a8edcc
Compare
Ryanf55
changed the title
src/CameraZoomPlugin.cc
Outdated
Comment on lines
173
to
177
| if (!this->scene) | ||
| { | ||
| this->scene = rendering::sceneFromFirstRenderEngine(); | ||
| if (!this->scene) { | ||
| gzerr << "Failed to get scene in InitialiseCamera()!\n"; | ||
| return; | ||
| } | ||
|
|
||
| } |
There was a problem hiding this comment.
Could we add the !this->scene check to the block that checks for initialisation?
if (this->scene == nullptr ||
!this->scene->IsInitialized() ||
this->scene->SensorCount() == 0)
{
Merged
Ryanf55
force-pushed
the
bugfix/camera-initialize-nullptr-crash
branch
from
5b3af1b
to
7f876a1
Compare
srmainwaring
approved these changes
Jan 25, 2024
|
@Ryanf55 - changed base to |
Signed-off-by: Ryan Friedman <ryanfriedman5410+github@gmail.com>
Signed-off-by: Ryan Friedman <ryanfriedman5410+github@gmail.com>
srmainwaring
force-pushed
the
bugfix/camera-initialize-nullptr-crash
branch
from
7f876a1
to
071163e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #77
Make sure to hit Play in gazebo for the image topic to show up!