Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing nav2 bringup dependency (and sort) #29

Merged

Conversation

Ryanf55
Copy link
Collaborator

@Ryanf55 Ryanf55 commented Oct 29, 2024

Purpose

I added a missing nav2_bringup dependency and sorted the rest.

Logs

Before this change on a fresh system

ryan@B650-970:~/Dev/ardu_ws$ ros2 launch ardupilot_ros navigation.launch.py
[INFO] [launch]: All log files can be found below /home/ryan/.ros/log/2024-10-29-06-27-47-422526-B650-970-523242
[INFO] [launch]: Default logging verbosity is set to INFO
[ERROR] [launch]: Caught exception in launch (see debug for traceback): Caught multiple exceptions when trying to load file of format [py]:
 - PackageNotFoundError: "package 'nav2_bringup' not found, searching: ['/home/ryan/Dev/ardu_ws/install/ardupilot_gz_bringup', '/home/ryan/Dev/ardu_ws/install/sdformat_urdf', '/home/ryan/Dev/ardu_ws/install/ardupilot_ros', '/home/ryan/Dev/ardu_ws/install/ros_gz_sim', '/home/ryan/Dev/ardu_ws/install/ros_gz_bridge', '/home/ryan/Dev/ardu_ws/install/ros_gz_interfaces', '/home/ryan/Dev/ardu_ws/install/ardupilot_dds_tests', '/home/ryan/Dev/ardu_ws/install/ardupilot_sitl', '/home/ryan/Dev/ardu_ws/install/micro_ros_agent', '/home/ryan/Dev/ardu_ws/install/ardupilot_sitl_models', '/home/ryan/Dev/ardu_ws/install/ardupilot_msgs', '/home/ryan/Dev/ardu_ws/install/ardupilot_gz_gazebo', '/home/ryan/Dev/ardu_ws/install/ardupilot_gz_description', '/home/ryan/Dev/ardu_ws/install/ardupilot_gazebo', '/opt/ros/humble']"
 - InvalidFrontendLaunchFileError: The launch file may have a syntax error, or its format is unknown
(failed reverse-i-search)`rosdep': ros2 launch ardupilot_^Cs navigation.launch.py

Copy link
Collaborator

@pedro-fuoco pedro-fuoco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. It's great to see that the project is still receiving PRs!

Seems like the failed test is an external issue with ardupilot_gazebo (pointed out by @srmainwaring #28 (comment)) we can merge as soon as that's fixed.

@Ryanf55
Copy link
Collaborator Author

Ryanf55 commented Oct 29, 2024

LGTM. It's great to see that the project is still receiving PRs!

I presented some slides from your GSOC project at the AP dev conference and there's some renewed interest in this work!

@pedro-fuoco
Copy link
Collaborator

I presented some slides from your GSOC project at the AP dev conference and there's some renewed interest in this work!

That's great news! I would love to catch up and get back to contributing, I will get in touch through discord.

Copy link
Collaborator

@srmainwaring srmainwaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Ryanf55
Copy link
Collaborator Author

Ryanf55 commented Oct 30, 2024

I'll fix conflicts

@Ryanf55 Ryanf55 force-pushed the fix-missing-nav2-bringup-dependency branch from a55d821 to 79dc93b Compare October 30, 2024 18:16
Signed-off-by: Ryan Friedman <25047695+Ryanf55@users.noreply.github.com>
@Ryanf55 Ryanf55 force-pushed the fix-missing-nav2-bringup-dependency branch from 79dc93b to 5bc9a4a Compare November 2, 2024 03:45
@Ryanf55 Ryanf55 merged commit 5c7086e into ArduPilot:humble Nov 2, 2024
2 checks passed
@Ryanf55 Ryanf55 deleted the fix-missing-nav2-bringup-dependency branch November 2, 2024 05:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants