Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ros2 interface #6343

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Ros2 interface #6343

wants to merge 1 commit into from

Conversation

Ryanf55
Copy link
Contributor

@Ryanf55 Ryanf55 commented Oct 20, 2024

Purpose

Start some documentation on the ROS interface on which channels are exposed. This also corrects a few related issues in the wiki docs.

Related PR's

This Wiki is up to date assuming the following PR's all get merged.

@Ryanf55 Ryanf55 force-pushed the ros2-interface branch 3 times, most recently from 13342bc to 4a2a08f Compare October 20, 2024 23:32
@Ryanf55
Copy link
Contributor Author

Ryanf55 commented Nov 3, 2024

@pedro-fuoco Can you review/add information to the TF , localization, and odometry sections? I'd like to make sure it has the info that your project figured out for GPS denied navigation.

dev/source/docs/ros2-interfaces.rst Outdated Show resolved Hide resolved
dev/source/docs/ros2-interfaces.rst Outdated Show resolved Hide resolved
dev/source/docs/ros2-interfaces.rst Show resolved Hide resolved
@pedro-fuoco
Copy link
Contributor

I will add information to the sections you requested tomorrow

Copy link
Contributor

@pedro-fuoco pedro-fuoco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do the services not have a table describing their types because they are using custom ardupilot types ?

Copy link
Contributor

@pedro-fuoco pedro-fuoco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let me know what you think about the additions I proposed. It would be best if the merge waited until /ap/pose/filtered is documented

Signed-off-by: Ryan Friedman <25047695+Ryanf55@users.noreply.github.com>
@Ryanf55
Copy link
Contributor Author

Ryanf55 commented Nov 12, 2024

Do the services not have a table describing their types because they are using custom ardupilot types ?

I just didn't have time to document them yet, Perhaps in a follow up they could be added.

Copy link
Contributor

@pedro-fuoco pedro-fuoco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, we can merge once the PR dependencies are done.
Thanks for the contribution @Ryanf55!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 👀 In review
Development

Successfully merging this pull request may close these issues.

2 participants