Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restored the old vlan functionality in create_wlan #136

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

markdegrootnl
Copy link

In e7e1540 the create_wlan function was update to use networkconf_id instead of the number of the vlan. This is correct for newer controllers, however breaks the functionality for older controllers.

I've added the possibility to specify the vlan either with a vlan id for version 5 controllers or with a networkconf_id for version 6 controllers.

@markdegrootnl
Copy link
Author

code-inspector says Function create_wlan is too long. Consider refactoring., not sure how to fix this.

@malle-pietje
Copy link
Collaborator

Looking into this again, apologies for the delayed response. Yeah, Code Inspector can be very strict, I'm actually surprised it allows the single class to be as long as it is:wink:

Looking at the change in parameters; if we do this it breaks other implementations that rely on the vlan_id parameter which you overwrite or am I misunderstanding your intent and changes?

@markdegrootnl
Copy link
Author

I've renamed the $vlan_id parameter to $networkconf_id for clarity. In my implementation you can either use $networkconf_id for controllers version 6 or $vlan for version 5 controllers.

If you don't want to support version 5 controllers, you can ignore this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants