Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tmin and tmax for knmi stations #239

Merged
merged 13 commits into from
Sep 23, 2024
Merged

Add tmin and tmax for knmi stations #239

merged 13 commits into from
Sep 23, 2024

Conversation

martinvonk
Copy link
Collaborator

@martinvonk martinvonk commented Sep 20, 2024

This pull request add the tmin, tmax data for the neerslag and meteo stations from the KNMI website.

@martinvonk martinvonk linked an issue Sep 20, 2024 that may be closed by this pull request
@OnnoEbbens
Copy link
Collaborator

OnnoEbbens commented Sep 23, 2024

The dataframe with stations have mixed types for the tmin and tmax columns (bool, None and str). I want to check if the values are not False. Ruff raises an error, E712 Avoid equality comparisons to 'False'; use 'if not stations_df["tmin"]:' for false checks. The suggestion does not work because of the mixed datatypes in the column. Therefore I decided to ignore the ruff E712 error for this file.

@ArtesiaWater ArtesiaWater merged commit 8975977 into dev Sep 23, 2024
7 checks passed
@OnnoEbbens OnnoEbbens deleted the knmi_stations branch September 23, 2024 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use start and end date for KNMI stations
4 participants