Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some KNMI fixes #243

Merged
merged 5 commits into from
Sep 27, 2024
Merged

Some KNMI fixes #243

merged 5 commits into from
Sep 27, 2024

Conversation

dbrakenhoff
Copy link
Collaborator

  • Fixes issue where current station has no data between start/end, and then is no longer present in stations dataframe, causing a KeyError.
  • Fixes issue so stations dataframe is not filtered when start and end are None.
  • Fixes issue for getting stations with meteo_var=slice(None), list all stations that have at least one of all possible meteo_vars. (Before this change hpd.io.knmi.get_station_name(739) was not working).

@dbrakenhoff dbrakenhoff self-assigned this Sep 27, 2024
@OnnoEbbens
Copy link
Collaborator

Hi Davíd, I shuffled the code a bit because I think that works better. Can you have a look? I already approved so if you like it you can merge the PR.

@dbrakenhoff
Copy link
Collaborator Author

Nice, this is even better. Merging.

@dbrakenhoff dbrakenhoff merged commit 2003523 into dev Sep 27, 2024
7 checks passed
@dbrakenhoff dbrakenhoff deleted the knmi_fixes branch September 27, 2024 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants