Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release 0.12.6: bugfix release #254

Merged
merged 29 commits into from
Jan 13, 2025
Merged

Release 0.12.6: bugfix release #254

merged 29 commits into from
Jan 13, 2025

Conversation

dbrakenhoff
Copy link
Collaborator

Bugfix release for #251. To be merged after merging #253.

Improvements to:

  • add leading zeros to station numbers KNMI
  • get_nearest_station for KNMI stations
  • fix bug in fill_missing_obs
  • deal with NaNs when merging metadata

New:

dbrakenhoff and others added 25 commits September 27, 2024 11:12
@dbrakenhoff
allow get_stations with meteo_var == slice(None)
2a9f7d8
@dbrakenhoff
only filter stations if start/end is provided
a3cbdf4
@dbrakenhoff
ensure current station is in dataframe so nearest station can be dete…
c256914 
…rmined
@OnnoEbbens
fix for knmi precipitation data station attribute is sometimes a seri…
17de5ab 
…es with duplicate entries #241 (#242)
@OnnoEbbens
reshuffle a bit
a17947b
@OnnoEbbens
ruff
2765ece
@dbrakenhoff
Merge pull request #243 from ArtesiaWater/knmi_fixes
2003523 
Some KNMI fixes
@dbrakenhoff
up version for minor release
4e124b6
@OnnoEbbens
version bump
d8b46a4
@OnnoEbbens
fix bug in fill_missing_obs
cd81586
@OnnoEbbens
version bump
a75f0a0
@OnnoEbbens
Merge branch 'master' into dev
fb5b542
@OnnoEbbens
ruff
211c958
@OnnoEbbens
Merge branch 'dev' of github.com:ArtesiaWater/hydropandas into dev
658ebbb
@OnnoEbbens
ruff
e27f10a
@OnnoEbbens
Merge branch 'master' into dev
af8b367
@OnnoEbbens
version bump
755759a
@OnnoEbbens
make exception for nan values in merge_metadata
c99c518
@martinvonk
add leading zeros to KNMI precipitation station name (#248)
990cc01 
* add leading zeros to station name
@OnnoEbbens
add example fews notebook (#249)
27f2048 
* add example fews notebook

* ruff

* fix error
@Florisklooster @OnnoEbbens
add 'check_consistency' boolean option to the 'to_excel' method (#250)
dc6b694 
* add 'check_consistency' boolean option to the 'to_excel' method

Add the possibility to not check on the consistency when using the to_excel method (implemented the same as is in the add_observation method).

* change in docstring to_excel method hydropandas/obs_collection.py

Co-authored-by: OnnoEbbens <onnoebbens@gmail.com>

---------

Co-authored-by: OnnoEbbens <onnoebbens@gmail.com>
@OnnoEbbens
install full in devcontainer
20060ee
@OnnoEbbens
Merge branch 'dev' of github.com:ArtesiaWater/hydropandas into dev
5826055
@dbrakenhoff
fix #251:
a4ab28e 
- adjust add_day values for daily rainfall files
- modify default add_day value in interpret_knmi_file
- add tests for checking raw and interpreted data vs stored files.
- add data files
@dbrakenhoff
up version for new releaes
41746a8
@dbrakenhoff dbrakenhoff self-assigned this Jan 10, 2025
rubencalje
rubencalje previously approved these changes Jan 10, 2025
View reviewed changes
Copy link
Collaborator

@rubencalje rubencalje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve after merging #253

@dbrakenhoff dbrakenhoff removed the request for review from martinvonk January 13, 2025 12:53
@martinvonk martinvonk self-requested a review January 13, 2025 13:01
martinvonk
martinvonk reviewed Jan 13, 2025
View reviewed changes
tests/data/2023-KNMI-test/uurgeg_260_1991-2000.txt
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe we could remove some lines from this file

martinvonk
martinvonk approved these changes Jan 13, 2025
View reviewed changes
Copy link
Collaborator

@martinvonk martinvonk left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Maybe we could reduce the size of the test files a little bit.

And who introduced this bug in the first place?
gif

@dbrakenhoff dbrakenhoff merged commit 8463e23 into master Jan 13, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martinvonk martinvonk martinvonk approved these changes

@rubencalje rubencalje rubencalje left review comments

Assignees

@dbrakenhoff dbrakenhoff

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@dbrakenhoff @rubencalje @martinvonk @OnnoEbbens @Florisklooster