Skip to content

Commit

Permalink
Adapt signal_jni file names in graalvm config
Browse files Browse the repository at this point in the history
  • Loading branch information
@AsamK
AsamK committed Sep 9, 2024
1 parent 6f9e9e9 commit 1d5d16f
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions graalvm-config-dir/resource-config.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -181,9 +181,9 @@
}, {
"pattern":"\\Qkotlin/reflect/reflect.kotlin_builtins\\E"
}, {
"pattern":"\\Qlibsignal_jni.dylib\\E"
"pattern":"\\Qlibsignal_jni_aarch64.dylib\\E"
}, {
"pattern":"\\Qlibsignal_jni.so\\E"
"pattern":"\\Qlibsignal_jni_amd64.dylib\\E"
}, {
"pattern":"\\Qlibsignal_jni_amd64.so\\E"
}, {
Expand All @@ -195,7 +195,7 @@
}, {
"pattern":"\\Qorg/sqlite/native/Linux/x86_64/libsqlitejdbc.so\\E"
}, {
"pattern":"\\Qsignal_jni.dll\\E"
"pattern":"\\Qsignal_jni_amd64.dll\\E"
}, {
"pattern":"\\Qsqlite-jdbc.properties\\E"
}, {
Expand Down

2 comments on commit 1d5d16f

@m-ueberall
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AsamK : Since you removed the patterns without architecture suffix the local build script will add it back, but if you keep it this way upstream – may I suggest to also list libsignal_jni_aarch64.so (or libsignal_jni_arm64.so, if you maybe want to add a mapping like for x86_64 vs amd64) and libsignal_jni_riscv64.so to cover all architectures supported by GraalVM? (Even if riscv64 support is still limited at the moment.)

@AsamK
Copy link
Owner Author

@AsamK AsamK commented on 1d5d16f Sep 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@m-ueberall I've added the patterns for files in the default libsignal-client build.
Feel free to create an MR with additional patterns, that may be usesful.

Please sign in to comment.