Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename mobile-coin-address to mobilecoin-address. #1638

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Rename mobile-coin-address to mobilecoin-address. #1638

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ceeda8c
Rename mobile-coin-address to mobilecoin-address.
christian-oudard Nov 28, 2024
7cd81a3
Support old param --mobile-coin-address as an alias.
christian-oudard Dec 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions client/src/cli.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -413,8 +413,8 @@ pub enum CliCommands {
#[arg(long = "about-emoji")]
about_emoji: Option<String>,

#[arg(long = "mobile-coin-address")]
mobile_coin_address: Option<String>,
#[arg(long = "mobilecoin-address")]
mobilecoin_address: Option<String>,

#[arg(long)]
avatar: Option<String>,
Expand Down
4 changes: 2 additions & 2 deletions client/src/main.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -371,7 +371,7 @@ async fn handle_command(
family_name,
about,
about_emoji,
mobile_coin_address,
mobilecoin_address,
avatar,
remove_avatar,
} => {
Expand All @@ -382,7 +382,7 @@ async fn handle_command(
family_name,
about,
about_emoji,
mobile_coin_address,
mobilecoin_address,
avatar,
remove_avatar,
)
Expand Down
2 changes: 1 addition & 1 deletion man/signal-cli.1.adoc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -651,7 +651,7 @@ Path to the new avatar image file.
*--remove-avatar*::
Remove the avatar

*--mobile-coin-address*::
*--mobilecoin-address*::
New MobileCoin address (Base64 encoded public address)

=== updateContact
Expand Down
2 changes: 1 addition & 1 deletion run_tests.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -209,7 +209,7 @@ for OUTPUT in "plain-text" "json"; do
done

## Profile
run_main -a "$NUMBER_1" updateProfile --given-name=GIVEN --family-name=FAMILY --about=ABOUT --about-emoji=EMOJI --avatar=LICENSE --mobile-coin-address="YWJjCg=="
run_main -a "$NUMBER_1" updateProfile --given-name=GIVEN --family-name=FAMILY --about=ABOUT --about-emoji=EMOJI --avatar=LICENSE --mobilecoin-address="YWJjCg=="

## Provisioning
link "$NUMBER_1"
Expand Down
5 changes: 3 additions & 2 deletions src/main/java/org/asamk/signal/commands/UpdateProfileCommand.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,8 @@ public void attachToSubparser(final Subparser subparser) {
subparser.addArgument("--family-name").help("New profile family name (optional)");
subparser.addArgument("--about").help("New profile about text");
subparser.addArgument("--about-emoji").help("New profile about emoji");
subparser.addArgument("--mobile-coin-address").help("New MobileCoin address (Base64 encoded public address)");
subparser.addArgument("--mobilecoin-address").help("New MobileCoin address (Base64 encoded public address)");
subparser.addArgument("--mobile-coin-address", "--mobilecoin-address") // Support legacy option name.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to add a semicolon here.


final var avatarOptions = subparser.addMutuallyExclusiveGroup();
avatarOptions.addArgument("--avatar").help("Path to new profile avatar");
Expand All @@ -42,7 +43,7 @@ public void handleCommand(
var familyName = ns.getString("family-name");
var about = ns.getString("about");
var aboutEmoji = ns.getString("about-emoji");
var mobileCoinAddressString = ns.getString("mobile-coin-address");
var mobileCoinAddressString = ns.getString("mobilecoin-address");
var mobileCoinAddress = mobileCoinAddressString == null
? null
: Base64.getDecoder().decode(mobileCoinAddressString);
Expand Down
Loading